zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: fix for SEGV
Date: Wed, 25 Aug 1999 15:37:41 +0000	[thread overview]
Message-ID: <990825153741.ZM24648@candle.brasslantern.com> (raw)
In-Reply-To: <199908241216.OAA09744@beta.informatik.hu-berlin.de>

On Aug 24,  2:16pm, Sven Wischnowsky wrote:
} Subject: PATCH: fix for SEGV
}
}   ...) ./zsh -f
}   % setopt autocd; hash wc=/bin/wc; echo|wc
} 
} It'll give you a SEGV in `isreallycom()', trying to look at
} `cn->u.name' which isn't set because for hashed commands `cn->u.cmd'
} is used.
} 
} +    if (cn->flags & HASHED)
} +	return 1;

Is that really the right fix?  I thought the whole point of isreallycom()
was to find cases where the hash table contains a mapping that doesn't
refer to a real executable.  I'm not sure it should succeed just because
the mapping was added explicitly.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


  reply	other threads:[~1999-08-25 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-08-24 12:16 Sven Wischnowsky
1999-08-25 15:37 ` Bart Schaefer [this message]
1999-08-26  7:16 Sven Wischnowsky
1999-08-27 16:04 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=990825153741.ZM24648@candle.brasslantern.com \
    --to=schaefer@candle.brasslantern.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).