From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: fix for SEGV
Date: Fri, 27 Aug 1999 16:04:05 +0000 [thread overview]
Message-ID: <990827160405.ZM28115@candle.brasslantern.com> (raw)
In-Reply-To: <199908260716.JAA14633@beta.informatik.hu-berlin.de>
On Aug 26, 9:16am, Sven Wischnowsky wrote:
} Subject: Re: PATCH: fix for SEGV
}
} Bart Schaefer wrote:
}
} > On Aug 24, 2:16pm, Sven Wischnowsky wrote:
} > } Subject: PATCH: fix for SEGV
} > }
} > } + if (cn->flags & HASHED)
} > } + return 1;
} >
} > Is that really the right fix?
}
} I wasn't sure either and was hoping for a reply. isreallycom() is used
} only in one place, so we could easily move the extra test there.
}
} - if (hn && trycd && !isreallycom((Cmdnam)hn)) {
} + if (hn && trycd && !(((Cmdnam)hn)->flags & HASHED) &&
} + !isreallycom((Cmdnam)hn)) {
Actually, I was rather thinking more of something like this (which goes
on top of 7490, which went on top of 7472):
Index: exec.c
===================================================================
@@ -617,9 +617,15 @@
{
char fullnam[MAXCMDLEN];
- strcpy(fullnam, cn->u.name ? *(cn->u.name) : "");
- strcat(fullnam, "/");
- strcat(fullnam, cn->nam);
+ if (cn->flags & HASHED)
+ strcpy(fullnam, cn->u.cmd);
+ else if (!cn->u.name)
+ return 0;
+ else {
+ strcpy(fullnam, cn->u.name);
+ strcat(fullnam, "/");
+ strcat(fullnam, cn->nam);
+ }
return iscom(fullnam);
}
@@ -1685,8 +1691,7 @@
char *cmdarg = (char *) peekfirst(args);
hn = cmdnamtab->getnode(cmdnamtab, cmdarg);
- if (hn && trycd && !(((Cmdnam)hn)->flags & HASHED) &&
- !isreallycom((Cmdnam)hn)) {
+ if (hn && trycd && !isreallycom((Cmdnam)hn)) {
cmdnamtab->removenode(cmdnamtab, cmdarg);
cmdnamtab->freenode(hn);
hn = NULL;
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1999-08-27 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-08-26 7:16 Sven Wischnowsky
1999-08-27 16:04 ` Bart Schaefer [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-08-24 12:16 Sven Wischnowsky
1999-08-25 15:37 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990827160405.ZM28115@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).