Re: 6-pws-2

[Peter Stephenson <pws@ibmth.df.unipi.it>]

"Bart Schaefer" wrote:
> Wow, good job, Peter!  The only ones you seem to have missed are:
> 
> 7414, fix info doc for makeinfo 3.12f

I didn't get that for some reason (or deleted it without applying it).

> 7436, change the way the last command in a pipeline is exec'd
> 
> Unless of course I missed the same ones you did, which is possible.  Truth
> to tell, I "missed" 7436 on purpose and was watching for whether you would
> include it -- did you intentionally leave it out?

See below.

> There does appear to be one other problem -- there is a complete copy of
> each of two versions of the _xterm completer in Completion/X/_xterm.  I
> think the top one is the one to keep.

This was fixed by Sven's patch, too.

Tanaka Akira wrote:
> > - There's an exec.c patch from Tanaka Akira, 7436, left out, because it was
> >   followed by an inconclusive discussion.  It's supposed to fix exec'ing
> >   the last element of the last pipeline.  I have not looked at the problem.
> 
> I think 7436 is the correct fix to the problem.

I finally looked at it and it seems fine.  I don't understand why it wasn't
working that way before.  Probably it was overlooked in some other changed.

> > - Personally, I prefer one single completion function for a suite of
> >   related commands
> 
> The separation is sometimes useful for custumizations because we can
> override each function individually. These functions behaves like `hook'.
> I think it is useful that making hooks more easily without adding new files.

This is a good point, maybe Sven's idea can help with this.  It would be
nice to keep it as function-based as possible.  Simplifying the initial
implementation (where you could define variables as well as functions) was
a big step to making the whole thing more usable.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy