From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: Zsh workers <zsh-workers@sunsite.auc.dk>
Subject: Re: Bug with _parameters and zmodload
Date: Thu, 02 Sep 1999 10:53:37 +0200 [thread overview]
Message-ID: <9909020853.AA21706@ibmth.df.unipi.it> (raw)
In-Reply-To: "Peter Stephenson"'s message of "Wed, 01 Sep 1999 18:09:50 DFT." <9909011609.AA21183@ibmth.df.unipi.it>
Peter Stephenson wrote:
> Oliver Kiddle wrote:
> > I got a number of error messages of the following form:
> >
> > _parameters: mapfile: autoload failed [43]
> >
> > I get it for each of parameters, functions, options, commands and mapfile
>
> This should fix this part.
Hmm, after thinking some more, maybe the following is a neater fix than
7616? I don't see why you should have to autoload any module just to unset
a parameter that hasn't yet been loaded, which is supposed to be what the
following prevents. The (paramtab == realparamtab) test makes sure it only
does the short cut for top level parameters, where we know what
paramtab->getnode does; I just copied it from createparam(), where I
presume it has a similar function (don't load a parameter if you're only
about to hide it).
--- Src/params.c.upm Mon Aug 30 16:14:05 1999
+++ Src/params.c Thu Sep 2 10:46:28 1999
@@ -1733,7 +1733,9 @@
{
Param pm;
- if ((pm = (Param) paramtab->getnode(paramtab, s)))
+ if ((pm = (Param) (paramtab == realparamtab ?
+ gethashnode2(paramtab, s) :
+ paramtab->getnode(paramtab, s))))
unsetparam_pm(pm, 0, 1);
}
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
next prev parent reply other threads:[~1999-09-02 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-01 16:01 Oliver Kiddle
1999-09-01 16:09 ` Peter Stephenson
1999-09-02 8:53 ` Peter Stephenson [this message]
1999-09-02 9:35 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9909020853.AA21706@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).