From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: 3.1.6-pws-3: bslashquote() is slightly messed up.
Date: Sun, 12 Sep 1999 22:41:47 +0000 [thread overview]
Message-ID: <990912224147.ZM23589@candle.brasslantern.com> (raw)
In-Reply-To: <rsq671gosz1.fsf@crane.jaist.ac.jp>
On Sep 13, 4:00am, Tanaka Akira wrote:
} Subject: Re: PATCH: 3.1.6-pws-3: bslashquote() is slightly messed up.
}
} In article <990912165419.ZM23254@candle.brasslantern.com>,
} "Bart Schaefer" <schaefer@candle.brasslantern.com> writes:
}
} > + DPUTS(!e || sf, "BUG: Wild pointer *e in bslashquote()");
}
} Hm. Is this really a bug? I think e == NULL is allowed.
Hm. It's really tricky to write the conditions for DPUTS(), partly because
I keep thinking in terms of assert(), of which DPUTS() is the reverse.
Index: utils.c
===================================================================
@@ -2999,7 +2999,7 @@
if (e && *e == u)
*e = v, sf = 1;
- DPUTS(!e || sf, "BUG: Wild pointer *e in bslashquote()");
+ DPUTS(e && !sf, "BUG: Wild pointer *e in bslashquote()");
return buf;
}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
prev parent reply other threads:[~1999-09-12 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-12 16:54 Bart Schaefer
1999-09-12 19:00 ` Tanaka Akira
1999-09-12 22:41 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990912224147.ZM23589@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).