zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: PATCH: 3.1.6-pws-4: zftp idiocies
Date: Wed, 15 Sep 1999 10:33:31 +0200	[thread overview]
Message-ID: <9909150833.AA30494@ibmth.df.unipi.it> (raw)

Quite by coincidence, two of the most stupid bugs ever introduced into an
FTP client appear in the zftp rmsession command.

--- Src/Modules/zftp.c.stupid	Fri Sep 10 11:57:43 1999
+++ Src/Modules/zftp.c	Wed Sep 15 10:30:32 1999
@@ -2772,7 +2772,7 @@
     char *newsess = NULL;
 
     /* Find the session in the list: either the current one, or by name */
-    for (no = 0, nptr = firstnode(zfsessions); nptr; no++, nptr++) {
+    for (no = 0, nptr = firstnode(zfsessions); nptr; no++, incnode(nptr)) {
 	sptr = (Zftp_session) nptr->dat;
 	if ((!*args && sptr == zfsess) ||
 	    (*args && !strcmp(sptr->name, *args)))
@@ -2794,7 +2794,7 @@
 	    LinkNode newn = firstnode(zfsessions);
 	    if (newn == nptr)
 		incnode(newn);
-	    newsess = ((Zftp_session)nptr->dat)->name;
+	    newsess = ((Zftp_session)newn->dat)->name;
 	}
     } else {
 	Zftp_session oldsess = zfsess;

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy


                 reply	other threads:[~1999-09-15  9:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9909150833.AA30494@ibmth.df.unipi.it \
    --to=pws@ibmth.df.unipi.it \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).