* PATCH: 3.1.6-pws-4: zftp idiocies
@ 1999-09-15 8:33 Peter Stephenson
0 siblings, 0 replies; only message in thread
From: Peter Stephenson @ 1999-09-15 8:33 UTC (permalink / raw)
To: Zsh hackers list
Quite by coincidence, two of the most stupid bugs ever introduced into an
FTP client appear in the zftp rmsession command.
--- Src/Modules/zftp.c.stupid Fri Sep 10 11:57:43 1999
+++ Src/Modules/zftp.c Wed Sep 15 10:30:32 1999
@@ -2772,7 +2772,7 @@
char *newsess = NULL;
/* Find the session in the list: either the current one, or by name */
- for (no = 0, nptr = firstnode(zfsessions); nptr; no++, nptr++) {
+ for (no = 0, nptr = firstnode(zfsessions); nptr; no++, incnode(nptr)) {
sptr = (Zftp_session) nptr->dat;
if ((!*args && sptr == zfsess) ||
(*args && !strcmp(sptr->name, *args)))
@@ -2794,7 +2794,7 @@
LinkNode newn = firstnode(zfsessions);
if (newn == nptr)
incnode(newn);
- newsess = ((Zftp_session)nptr->dat)->name;
+ newsess = ((Zftp_session)newn->dat)->name;
}
} else {
Zftp_session oldsess = zfsess;
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~1999-09-15 9:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-09-15 8:33 PATCH: 3.1.6-pws-4: zftp idiocies Peter Stephenson
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).