From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 693 invoked from network); 15 Sep 1999 09:08:51 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 15 Sep 1999 09:08:51 -0000 Received: (qmail 11556 invoked by alias); 15 Sep 1999 09:08:46 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 7836 Received: (qmail 11547 invoked from network); 15 Sep 1999 09:08:43 -0000 Message-Id: <9909150833.AA30494@ibmth.df.unipi.it> To: zsh-workers@sunsite.auc.dk (Zsh hackers list) Subject: PATCH: 3.1.6-pws-4: zftp idiocies Date: Wed, 15 Sep 1999 10:33:31 +0200 From: Peter Stephenson Quite by coincidence, two of the most stupid bugs ever introduced into an FTP client appear in the zftp rmsession command. --- Src/Modules/zftp.c.stupid Fri Sep 10 11:57:43 1999 +++ Src/Modules/zftp.c Wed Sep 15 10:30:32 1999 @@ -2772,7 +2772,7 @@ char *newsess = NULL; /* Find the session in the list: either the current one, or by name */ - for (no = 0, nptr = firstnode(zfsessions); nptr; no++, nptr++) { + for (no = 0, nptr = firstnode(zfsessions); nptr; no++, incnode(nptr)) { sptr = (Zftp_session) nptr->dat; if ((!*args && sptr == zfsess) || (*args && !strcmp(sptr->name, *args))) @@ -2794,7 +2794,7 @@ LinkNode newn = firstnode(zfsessions); if (newn == nptr) incnode(newn); - newsess = ((Zftp_session)nptr->dat)->name; + newsess = ((Zftp_session)newn->dat)->name; } } else { Zftp_session oldsess = zfsess; -- Peter Stephenson Tel: +39 050 844536 WWW: http://www.ifh.de/~pws/ Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy