From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: 3.1.6-pws-6: $compstate[unambiguous] could be garbage
Date: Thu, 7 Oct 1999 10:40:18 +0000 [thread overview]
Message-ID: <991007104018.ZM25846@candle.brasslantern.com> (raw)
Earlier today I started noticing
_main_complete: 95: bad set of key/value pairs for associative array
Line 95 is copying the entire $compstate assoc int $lastcomp. I eventually
tracked the problem to the value of `unambiguous' which it seemed was being
dropped from the ${(@kv)compstate} expansion. Turns out the reason it was
being dropped is that it pointed to a garbage string because unambig_data()
was being called twice and was freeing and reallocating the cached value
each time; the string returned the first time ended up pointing into free
memory.
I don't know whether the `|| !ainfo' is necessary in the patch below, but
it seemed safest to have it there. It was always nonzero in the bug case,
but I didn't go through every possible call to the function.
Index: Src/Zle/zle_tricky.c
===================================================================
@@ -7963,7 +7963,7 @@
scache = cline_str((ainfo->count ? ainfo->line : fainfo->line),
0, &ccache);
}
- } else {
+ } else if (mnum != unambig_mnum || !ainfo || !scache) {
zsfree(scache);
scache = ztrdup("");
ccache = 0;
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next reply other threads:[~1999-10-07 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-07 10:40 Bart Schaefer [this message]
1999-10-07 17:30 ` Clint Adams
1999-10-07 21:36 ` Bart Schaefer
1999-10-08 7:46 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991007104018.ZM25846@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).