From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Zsh workers <zsh-workers@sunsite.auc.dk>
Subject: Re: Alternate patch Re: PATCH: New prompt themes
Date: Thu, 21 Oct 1999 15:09:11 +0000 [thread overview]
Message-ID: <991021150912.ZM10260@candle.brasslantern.com> (raw)
In-Reply-To: <380ED4B0.CB258973@u.genie.co.uk>
On Oct 21, 9:54am, Oliver Kiddle wrote:
} Subject: Re: Alternate patch Re: PATCH: New prompt themes
}
} > Further, I might suggest that instead of an assoc. array with both set and
} > unset values, just use a regular array of only the values that are meant to
} > be set; e.g. one command instead of a loop:
} > setopt noprompt{bang,cr,percent,subst} prompt$^prompt_opts
} > However, I didn't make that change either.
}
} That probably is better. An alternative patch to do it that way
} follows.
In that case:
Index: Functions/Prompts/prompt_oliver_setup
===================================================================
@@ -17,7 +17,7 @@
}
prompt_oliver_setup() {
- prompt_opts=( percent set )
+ prompt_opts=( percent )
local pcol=$'\e['${1:-${pcolour[${HOST:=`hostname`}]:-33}}m
local tcol=$'\e['${2:-${tcolour[$HOST]:-37}}m
} The only thing I'm not sure about is whether it is wise that
} promptcr is controlled by the prompt themes. I'd consider it to be
} down to personal preference whether it's set or not. I also can't see
} that it could be crucial to a particular theme so you might want to
} remove cr from the brace expansion.
I can't make up my mind about this. If you're going to remove it from
the brace expansion, then you should probably also filter it out of the
value of prompt_opts. On the other hand, almost no fancy prompt -- and
certainly not one that uses the width of the screen and/or an RPROMPT --
works correctly when promptcr is turned off. Even Zle doesn't work very
well when it only thinks it started out in the leftmost column.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
prev parent reply other threads:[~1999-10-21 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-19 19:11 Oliver Kiddle
1999-10-20 0:40 ` Bart Schaefer
1999-10-20 4:16 ` Alternate patch " Bart Schaefer
1999-10-21 8:54 ` Oliver Kiddle
1999-10-21 15:09 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991021150912.ZM10260@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).