From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: math and locale
Date: Sat, 20 Nov 1999 20:53:31 +0000 [thread overview]
Message-ID: <991120205331.ZM15647@candle.brasslantern.com> (raw)
In-Reply-To: <19991120151807.A22546@dman.com>
On Nov 20, 3:18pm, Clint Adams wrote:
} Subject: PATCH: math and locale
}
} This alleviates the decimal point problem by making it
} locale-independent. This reverses the previous fix
} which introduced new problems.
Here's the equivalent against 3.1.6-bart-8, for those of you who, like me,
never applied Clint's previous patch and hence don't need to reverse it.
I'm mildly concerned that setting and restoring the locale is an excessive
overhead, especially if it's a no-op (prev_local is already "POSIX" or "C").
Can anyone reassure me?
I also wonder whether "C" would not be a better choice than "POSIX" here.
Index: Src/math.c
===================================================================
@@ -184,6 +184,9 @@
static int
zzlex(void)
{
+#ifdef USE_LOCALE
+ char *prev_locale;
+#endif
int cct = 0;
yyval.type = MN_INTEGER;
@@ -356,7 +359,14 @@
if (*nptr == '.' || *nptr == 'e' || *nptr == 'E') {
/* it's a float */
yyval.type = MN_FLOAT;
+#ifdef USE_LOCALE
+ prev_locale = setlocale(LC_NUMERIC, NULL);
+ setlocale(LC_NUMERIC, "POSIX");
+#endif
yyval.u.d = strtod(ptr, &nptr);
+#ifdef USE_LOCALE
+ setlocale(LC_NUMERIC, prev_locale);
+#endif
if (ptr == nptr || *nptr == '.') {
zerr("bad floating point constant", NULL, 0);
return EOI;
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1999-11-20 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-11-20 20:18 Clint Adams
1999-11-20 20:53 ` Bart Schaefer [this message]
1999-11-21 18:14 ` Clint Adams
1999-11-22 8:17 ` Bart Schaefer
1999-11-22 14:42 ` Clint Adams
1999-11-22 18:23 ` Bart Schaefer
1999-11-22 19:36 ` Clint Adams
1999-11-22 20:03 ` Zefram
1999-11-23 18:18 ` Bart Schaefer
1999-11-26 22:08 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991120205331.ZM15647@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).