zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: "O. simplex" <ordinatio.simplex@protonmail.ch>,
	"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Solution: Bu report - unix/_gpg completion broken
Date: Wed, 10 Jun 2020 01:07:13 +0200	[thread overview]
Message-ID: <99116-1591744033.948885@zagI.gwnq.OfJE> (raw)
In-Reply-To: <20200606081909.33d488c5@tarpaulin.shahaf.local2>

On 6 Jun, Daniel Shahaf wrote:
> --- a/Completion/compinit
> @@ -159,6 +159,7 @@ _comp_options=(
> +    NO_shfileexpansion

Stuffing extra options into _comp_options is usually a bad idea because
it prevents the completion system from honouring the user's preferences.
In this case _expand will no longer handle the correct precedence of ~
and brace expansion.

It looks to me like the shfileexpansion option has got broken more
fundamentally at some point. Swap the = and : in the character
class in the pattern on the line that produces an error and the error
goes away. _complete_debug also appears to be broken with
shfileexpansion:

  setopt shfileexpansion; : =(echo hi)

I've not bisected fully but I did check a very old zsh and it worked
fine with that.

Oliver


  reply	other threads:[~2020-06-09 23:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01  1:42 O. simplex
2020-05-15  5:21 ` Solution: " O. simplex
2020-05-15  8:53   ` Daniel Shahaf
     [not found]     ` <Ww4N4kk6TH_2Cp6_B0A709kTrD8LonXJPl6qmAAx75k0eQ7OczWUSwo7LCJOnXJm-nyuAVtdf8HOIGGb0krLeM0Z_fRWy723j1XTVA6vgek=@protonmail.ch>
2020-06-06  6:38       ` O. simplex
2020-06-06  8:19         ` Daniel Shahaf
2020-06-09 23:07           ` Oliver Kiddle [this message]
2020-06-10 13:44             ` Daniel Shahaf
2020-06-23 21:23               ` SH_FILE_EXPANSION broken with process substitution Oliver Kiddle
2020-06-24 10:28                 ` Peter Stephenson
2020-06-24 10:46                   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99116-1591744033.948885@zagI.gwnq.OfJE \
    --to=okiddle@yahoo.co.uk \
    --cc=d.s@daniel.shahaf.name \
    --cc=ordinatio.simplex@protonmail.ch \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).