Bug report

[Patrick Oscity <patrick.oscity@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]

Dear zsh team,

I think I might have found a bug in zsh. Here is my bug report:

Steps to reproduce

	* add a simple RPROMPT to ~/.zshrc, e.g. RPROMPT='X'
	* optionally set PROMPT='$ ' to avoid side-effects of escape
	  sequences like color codes etc.

Actual outcome

	* the right prompt is not right aligned, it is in fact shifted to the
	  left by one character
	* this means that there is one character of space wasted
	* it is also optically disturbing, e.g. when using tmux and the
	  right prompt does not align with tmux's status bar

Expected outcome

	* the right prompt should be right aligned, using the full
	  available width of the terminal

Attached is a diff for zle_refresh.c that fixes the issue for me, although I now have to compile zsh myself. It would however be great to see this corrected in an official release of zsh. Thanks for your consideration!

Best,
Patrick


[-- Attachment #1.2: zle_refresh.c.diff --]
[-- Type: application/octet-stream, Size: 852 bytes --]

diff --git a/Src/Zle/zle_refresh.c b/Src/Zle/zle_refresh.c
index 17b78ce..f136178 100644
--- a/Src/Zle/zle_refresh.c
+++ b/Src/Zle/zle_refresh.c
@@ -1576,7 +1576,7 @@ zrefresh(void)
 	else
 	    put_rpmpt = rprompth == 1 && rpromptbuf[0] &&
 		!strchr(rpromptbuf, '\t') &&
-		(int)ZR_strlen(nbuf[0]) + rpromptw < winw - 1;
+		(int)ZR_strlen(nbuf[0]) + rpromptw < winw;
     } else {
 /* insert >.... on first line if there is more text before start of screen */
 	ZR_memset(nbuf[0], zr_sp, lpromptw);
@@ -1631,9 +1631,9 @@ zrefresh(void)
 	if (put_rpmpt && !iln && !oput_rpmpt) {
 	    int attrchange;
 
-	    moveto(0, winw - 1 - rpromptw);
+	    moveto(0, winw - rpromptw);
 	    zputs(rpromptbuf, shout);
-	    vcs = winw - 1;
+	    vcs = winw;
 	/* reset character attributes to that set by the main prompt */
 	    txtchange = pmpt_attr;
 	    /*

[-- Attachment #1.3: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]