From: dana <dana@dana.is>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: Only use fg_start_code for non-truecolor
Date: Tue, 22 Jan 2019 23:05:44 -0600 [thread overview]
Message-ID: <9ED0C01E-6BC3-4B2C-A1CA-B807258F4D3B@dana.is> (raw)
In-Reply-To: <20190123000615.22241-1-mikachu@gmail.com>
On 22 Jan 2019, at 18:06, Mikael Magnusson <mikachu@gmail.com> wrote:
>This fixes my prompt. We could possibly add a [fb]g_24bit_start_code or
>something if anyone feels it's necessary.
I tested this on macOS and it seems OK. At least, it makes sense to me, and it
appears to work as described.
As for the file-completion thing (workers/44009), if my opinion is wanted: I
think i would have worked around it in 'user land' myself, but i don't feel
strongly either way. If coming to a firm conclusion on it might delay getting
5.7 into Buster, we could revert it pending further discussion? idk.
In any case, do we need one more test release after this fix goes in? Or does
it look safe enough?
dana
next prev parent reply other threads:[~2019-01-23 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 0:06 Mikael Magnusson
2019-01-23 5:05 ` dana [this message]
2019-01-23 9:34 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ED0C01E-6BC3-4B2C-A1CA-B807258F4D3B@dana.is \
--to=dana@dana.is \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).