From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d7fe5644 for ; Wed, 23 Jan 2019 05:06:03 +0000 (UTC) Received: (qmail 20627 invoked by alias); 23 Jan 2019 05:05:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44013 Received: (qmail 8248 invoked by uid 1010); 23 Jan 2019 05:05:49 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f176.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.166.176):SA:0(-1.9/5.0):. Processed in 0.822082 secs); 23 Jan 2019 05:05:49 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tBtf1xWLLWN26UjlMHBxwb5Ws0qgj7NGXKz02KwKXq8=; b=BD3+Ek3qzijD5MQUoJw0U9aKSPAq9NzrF0yDkA9IEBn8YIZ+13Aidr5LDNn/Yo8jLt pOXh/BhasV1e+tFHMPrO7tPMOJmsAPMAGmJGh03mjW+T+6Uiis9SVnmbBvBzrWxC7J++ A9GHc41imX20J2nu4yTiD4CeDmjXqEh2yy9poS9qWn2UDYVy4hnrrpJQnGvGV0mVhGrE 58IpTSApaROWjvU4rQBCX5SRVIGt52y+zKU3TGikPFfqPpb+oVu+gGs9x+mm/1wMnOMK 9S5mzVZ0LixCeGNc/WcsX70k3oYxrimfyicJwYZJ3WIOkITtJ0NSfuSdW1GXvBv9pAJ6 K1OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tBtf1xWLLWN26UjlMHBxwb5Ws0qgj7NGXKz02KwKXq8=; b=sMS5zHIQSAmNImMSDfbVLprUN/r6P3p9h0jLlo/X+pMQgppCnja0ikCEx43RWAwl+O Z4U+9oOUC77NhUOFRZrXkzxcEnhGqdHz2SlQignuhpnSjOZ3/s74krqJtYizTHr7+j/v m3EfDuxhPwrRo0gYD+JO32jLJgik5jI1z53HVlAw7YJv2RQbAHoxjKj6OGz1xKjMhXop nftrPMgwkFts+tvp90QKyAOqe4XlB9BZAm2BWbqqzy2ZtJphOs5veemy+bjA2/vF0IUE RLLzxdKGHugcouV25W5H5kEtD1JCGOs0GXfk45e06rsRwUbMyoceZB/+BQl8n8AO8ivU i5Jg== X-Gm-Message-State: AJcUukfVE3afu1UL3uXjZjh7sYyqU4lnyJNoeM6g4RINoiOgZlGUxL4Q pnnpBc4Dv1AFclE30Rj7aaig2E+LUic= X-Google-Smtp-Source: ALg8bN7atRXojwsyZ+uzbU59NyllnqAVZKBLYZZSKLK4K6qch7iHuUTYRklatjw/SvFwim+rWYz0zg== X-Received: by 2002:a24:19d5:: with SMTP id b204mr792921itb.6.1548219946374; Tue, 22 Jan 2019 21:05:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: PATCH: Only use fg_start_code for non-truecolor From: dana In-Reply-To: <20190123000615.22241-1-mikachu@gmail.com> Date: Tue, 22 Jan 2019 23:05:44 -0600 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: <9ED0C01E-6BC3-4B2C-A1CA-B807258F4D3B@dana.is> References: <20190123000615.22241-1-mikachu@gmail.com> To: Mikael Magnusson X-Mailer: Apple Mail (2.3445.100.39) On 22 Jan 2019, at 18:06, Mikael Magnusson wrote: >This fixes my prompt. We could possibly add a [fb]g_24bit_start_code or >something if anyone feels it's necessary. I tested this on macOS and it seems OK. At least, it makes sense to me, = and it appears to work as described. As for the file-completion thing (workers/44009), if my opinion is = wanted: I think i would have worked around it in 'user land' myself, but i don't = feel strongly either way. If coming to a firm conclusion on it might delay = getting 5.7 into Buster, we could revert it pending further discussion? idk. In any case, do we need one more test release after this fix goes in? Or = does it look safe enough? dana