From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Lawrence Velázquez" <vq@larryv.me>, zsh-workers@zsh.org
Subject: Re: EOL normalization? (Was: Completion script for the ctags program)
Date: Mon, 29 Mar 2021 15:34:32 +0000 [thread overview]
Message-ID: <9c2d7f89-d521-4397-b8f0-1cea03126446@www.fastmail.com> (raw)
In-Reply-To: <abf3f00d-04c0-4492-8c22-89e436947734@www.fastmail.com>
Lawrence Velázquez wrote on Mon, 29 Mar 2021 15:07 +00:00:
> On Mon, Mar 29, 2021, at 4:54 AM, Peter Stephenson wrote:
> >
> > > On 29 March 2021 at 00:29 Oliver Kiddle <opk@zsh.org> wrote:
> > > The previous files also had DOS
> > > line endings - if someone other than me pushes any updates, please
> > > ensure we only have Unix line endings.
> >
> > That would likely be my fault because on that occasion I extracted the script
> > from the original email in a somewhat clumsy cross-platform way. It was
> > inconvenient and bug-prone enough I'm likely to be leaving anything like
> > this in future until I'm back on a proper Linux system...
>
> Would it be desirable to normalize line endings on commit (see
> https://git-scm.com/docs/gitattributes#_end_of_line_conversion)?
I for one would rather Git treated file contents as opaque binary blobs
and didn't munge them in any way. That tends to be a lot easier if we
ever need to surgery the repository, or if we want to add CRLF or binary
test data, or if somebody uses a Windows Git client to build zsh on
Cygwin — and as to downsides, it's not as though CRLF in the completion
files are a common problem, or one that's hard to notice/fix when it
does occur.
Cheers,
Daniel
>
>
>
> diff --git a/.gitattributes b/.gitattributes
> new file mode 100644
> index 000000000..0a192b762
> --- /dev/null
> +++ b/.gitattributes
> @@ -0,0 +1,2 @@
> +# Normalize EOLs to LF in files that look like text.
> +* text=auto
>
>
next prev parent reply other threads:[~2021-03-29 15:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 3:11 Completion script for the ctags program Jacob Gelbman
2021-02-23 10:11 ` Peter Stephenson
2021-02-23 22:20 ` Oliver Kiddle
2021-02-23 22:45 ` Bart Schaefer
2021-02-23 23:51 ` Oliver Kiddle
2021-02-24 0:52 ` Bart Schaefer
2021-02-24 13:47 ` Daniel Shahaf
2021-02-23 23:05 ` Mikael Magnusson
2021-02-23 21:39 ` Oliver Kiddle
2021-02-24 4:45 ` Jacob Gelbman
2021-02-24 7:20 ` Jacob Gelbman
2021-02-24 9:26 ` Peter Stephenson
2021-02-24 14:24 ` Daniel Shahaf
2021-02-24 18:58 ` Jacob Gelbman
2021-02-24 19:01 ` Bart Schaefer
2021-03-03 20:02 ` Daniel Shahaf
2021-03-03 20:39 ` Jacob Gelbman
2021-03-03 21:40 ` Peter Stephenson
2021-03-03 22:06 ` Daniel Shahaf
2021-03-03 22:08 ` Jacob Gelbman
2021-03-03 23:28 ` Aaron Schrab
2021-03-03 23:43 ` Daniel Shahaf
2021-03-03 23:35 ` Daniel Shahaf
2021-03-07 19:18 ` Jacob Gelbman
2021-03-07 21:42 ` Daniel Shahaf
2021-03-07 21:57 ` Jacob Gelbman
2021-03-07 22:10 ` Daniel Shahaf
2021-03-11 16:15 ` Daniel Shahaf
2021-03-11 17:08 ` Jacob Gelbman
2021-03-20 1:43 ` Lawrence Velázquez
2021-03-27 16:14 ` Lawrence Velázquez
2021-03-27 20:43 ` Daniel Shahaf
2021-03-28 23:29 ` Oliver Kiddle
2021-03-29 8:54 ` Peter Stephenson
2021-03-29 15:07 ` EOL normalization? (Was: Completion script for the ctags program) Lawrence Velázquez
2021-03-29 15:34 ` Daniel Shahaf [this message]
2021-03-29 15:41 ` Lawrence Velázquez
2021-02-24 21:54 ` Completion script for the ctags program dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c2d7f89-d521-4397-b8f0-1cea03126446@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=vq@larryv.me \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).