zsh-workers
 help / color / mirror / code / Atom feed
From: Chris Down <chris@chrisdown.name>
To: zsh-workers@zsh.org
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>
Subject: [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec
Date: Mon, 17 Feb 2020 10:12:02 -0500	[thread overview]
Message-ID: <9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name> (raw)
In-Reply-To: <c02a0a26bf4c82b1e227053337a4c71525504574.1581952273.git.chris@chrisdown.name>

The version without a sigspec can't be added yet because it would still
kill the test runner even in expected-to-fail mode, see workers/45449
for discussion. For the same reason, we use a signal which is non-fatal
by default and unlikely to be sent by someone else, SIGURG, to do the
expected-to-fail case prior to the fix.
---
 Test/B11kill.ztst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Test/B11kill.ztst b/Test/B11kill.ztst
index c254b0925..fe2da1012 100644
--- a/Test/B11kill.ztst
+++ b/Test/B11kill.ztst
@@ -58,3 +58,12 @@
   )
 1:kill with sigspec only
 ?(eval):kill:2: not enough arguments
+
+# Regression tests: `kill ''` should not result in `kill 0`.
+
+  (
+    trap 'exit 11' URG
+    kill -URG ''
+  )
+1f:kill with empty pid and sigspec should not send signal to current process group
+?(eval):kill:3: illegal pid: 
-- 
2.25.0


  reply	other threads:[~2020-02-17 15:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 15:11 [PATCH v3 1/3] builtins: kill: Add basic test suite Chris Down
2020-02-17 15:12 ` Chris Down [this message]
2020-02-17 15:12   ` [PATCH v3 3/3] builtins: kill: Do not signal current process group when pid is empty Chris Down
2020-02-18 13:04   ` [PATCH v3 2/3] builtins: kill: Add `kill ''` regression test with explicit sigspec Daniel Shahaf
2020-02-18 15:26     ` Chris Down
2020-02-18 16:42       ` Daniel Shahaf
2020-02-18 18:50         ` Chris Down
2020-02-18 19:37           ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cd0633db0d2e6d5238c98426bf18a0946e81c60.1581952273.git.chris@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).