From: mason@primenet.com.au (Geoff Wing)
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: 4.1.0: mkstemp
Date: Sat, 16 Jun 2001 06:48:17 +0000 (UTC) [thread overview]
Message-ID: <9gevfh$abj$1@coral.primenet.com.au> (raw)
In-Reply-To: <Pine.LNX.4.33L2.0106151654030.8874-100000@phong.blorf.net>
Wayne Davison <wayned@users.sourceforge.net> typed:
: On Sat, 16 Jun 2001, Peter Stephenson wrote:
:> gcc has taken to complaining about using mktemp() instead of mkstemp().
: Since mkstemp() returns a file handle, not a file name, I reverted the
: code in util.c back to how it was.
Of course, given it's just about certain to be immediately clobbered by
the following lines . . . .
Peter did that around 10pm on a Friday night; he must have just come
back from the pub. Oops :-)
....
+#ifdef HAVE_MKSTEMP
+ ret = ((char *) mkstemp(dyncat(unmeta(s), "XXXXXX")));
#ifdef HAVE__MKTEMP
/* Zsh uses mktemp() safely, so silence the warnings */
ret = ((char *) _mktemp(dyncat(unmeta(s), "XXXXXX")));
#else
ret = ((char *) mktemp(dyncat(unmeta(s), "XXXXXX")));
+#endif
#endif
unqueue_signals();
....
Regards,
--
Geoff Wing : <gcw@pobox.com>
Rxvt Stuff : <gcw@rxvt.org>
Zsh Stuff : <gcw@zsh.org>
prev parent reply other threads:[~2001-06-16 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-15 23:14 Peter Stephenson
2001-06-15 23:56 ` Wayne Davison
2001-06-16 3:07 ` Bart Schaefer
2001-06-16 6:24 ` Wayne Davison
2001-06-16 6:48 ` Geoff Wing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='9gevfh$abj$1@coral.primenet.com.au' \
--to=mason@primenet.com.au \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).