From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d31c316a for ; Tue, 12 Mar 2019 07:56:03 +0000 (UTC) Received: (qmail 1784 invoked by alias); 12 Mar 2019 07:55:50 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44118 Received: (qmail 6845 invoked by uid 1010); 12 Mar 2019 07:55:50 -0000 X-Qmail-Scanner-Diagnostics: from rcpt-expgw.biglobe.ne.jp by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25384. spamassassin: 3.4.2. Clear:RC:0(133.208.98.2):SA:0(-2.6/5.0):. Processed in 4.181642 secs); 12 Mar 2019 07:55:50 -0000 X-Envelope-From: takimoto-j@kba.biglobe.ne.jp X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.98.2 as permitted sender) X-Biglobe-Sender: From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH 1/3] Move readhistfile() after flockhistfile(). Date: Tue, 12 Mar 2019 16:55:11 +0900 References: <70520d027e2f5ddc09b2c78d543664b52341f450.camel@fifi.org> <20190309005442.944477-1-phil+github-commits@fifi.org> <82f4a6db638fbfce396e64a45029424185863068.camel@fifi.org> <3228a3e68f2580fc25a9fda9bf7ccf5ce9a73689.camel@fifi.org> To: zsh-workers@zsh.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.102.3) X-Biglobe-Spnum: 56097 > 2019/03/12 6:04, Jason L Tibbitts III wrote: > >>>>>> "BS" == Bart Schaefer writes: > > BS> I don't know Fedora very well; feedback from the list would be > BS> beneficial. > > Note that Fedora in general doesn't have this problem. I can certainly > build the zsh source RPM without issues on my Fedora systems, The problem occurs only if HAVE_NIS is defined, and it is defined only if you are using NIS. In configure.ac, line 2083: AH_TEMPLATE([HAVE_NIS], [Define to 1 if you have NIS.]) AC_CACHE_CHECK(for NIS, zsh_cv_sys_nis, [test -f /usr/bin/ypcat && /usr/bin/ypcat passwd.byname > /dev/null 2>&1 && \ zsh_cv_sys_nis=yes || zsh_cv_sys_nis=no]) if test x$zsh_cv_sys_nis = xyes; then AC_DEFINE(HAVE_NIS) fi so HAVE_NIS is defined only if "ypcat passwd.byname" succeeds, i.e., only if you are currently using NIS on your Fedora box. RPC is removed from glibc-2.26; on Fedora 28 or later (and probably on other recent/future distributions which use glib-2.26 or later) RPC is in libtirpc whose headers are in /usr/include/tirpc/. Below is a simple patch, but it is "minimal" and feel free to extend it. # Is it better to allow anyone who has required libraries to build # NIS-aware zsh even if he/she is not using NIS? Or add an option # like --enable-nis? diff --git a/configure.ac b/configure.ac index 5513e25f1..8a2664ed2 100644 --- a/configure.ac +++ b/configure.ac @@ -2087,6 +2087,10 @@ AC_CACHE_CHECK(for NIS, zsh_cv_sys_nis, zsh_cv_sys_nis=yes || zsh_cv_sys_nis=no]) if test x$zsh_cv_sys_nis = xyes; then AC_DEFINE(HAVE_NIS) +dnl RPC is removed from glibc-2.26 and replaced by libtirpc + AC_CHECK_HEADER(rpc/rpc.h, [], + [test -f /usr/include/tirpc/rpc/rpc.h && \ + CPPFLAGS="$CPPFLAGS -I/usr/include/tirpc"]) dnl Some systems (Solaris 2.x, Linux Redhat 5.x) require dnl libnsl (Network Services Library) to find yp_all AC_SEARCH_LIBS(yp_all, nsl)