help / color / mirror / code / Atom feed
From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: Hang in E01 due to zpty on OpenBSD
Date: Thu, 7 Apr 2022 12:47:18 +0900	[thread overview]
Message-ID: <A293E54B-5AEC-43D9-8C3C-B55081DDD912@kba.biglobe.ne.jp> (raw)
In-Reply-To: <Yk2NU2krjfBGnQBu@CptOrmolo.darkstar>

> 2022/04/06 21:53, Matthew Martin <phy1729@gmail.com> wrote:
> I'd prefer something like the below where it's a feature test instead of
> an OS test.

I was thinking that we should better minimize the possible side effects
just before the new release.

If we use your patch (with some fixes) openpty() will be used on ALL systems
(Linux, other BSDs and macOS, ...) if it is available. Is this what you
want to achieve? It may work but we need to test on lots of systems.

> diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c
> +#elifdef USE_DEV_PTMX
#elif defined(USE_DEV_PTMX)

> -#elif defined(__OpenBSD__)
> -    static char char1[] = "pqrstuvwxyzPQRST";
> -    static char char2[] = "0123456789"
> -                          "abcdefghijklmnopqrstuvwxyz"
> -                          "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
I think we need to keep this in case openpty() is not available on OpenBSD.

> diff --git a/configure.ac b/configure.ac
> +AC_MSG_CHECKING([for openpty])
> +openpty=no

We need to call AC_SEARCH_LIBS(openpty, util) here to add -lutil to LIBS.
Otherwise the following two AC_LINK_IFELSE() fail and openpty() will never
be used.

  parent reply	other threads:[~2022-04-07  3:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 21:42 Matthew Martin
2022-04-04  1:04 ` Bart Schaefer
2022-04-04  2:34   ` Matthew Martin
2022-04-04  3:49     ` Matthew Martin
2022-04-04  8:34       ` Jun T
2022-04-04 11:21         ` Mikael Magnusson
2022-04-04 13:16         ` Matthew Martin
2022-04-06  5:48           ` Jun T
2022-04-06 12:53             ` Matthew Martin
2022-04-06 20:12               ` Bart Schaefer
2022-04-07  3:47               ` Jun T [this message]
2022-04-07  4:52                 ` Matthew Martin
2022-04-08  7:51                   ` Jun T
2022-04-04  2:39 ` Jun T
2022-04-04  2:51   ` Matthew Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A293E54B-5AEC-43D9-8C3C-B55081DDD912@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).