From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9130 invoked from network); 7 Apr 2022 03:47:47 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Apr 2022 03:47:47 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1649303267; b=ShBc3tS2uSzICKiwt96Mz0b++EiGKrdjnMlnH3mjIuoXKjJfHHh5QNitUaOrlW/nlhUi8UfyDS 2bCwhO22rtlkdP/NiVZA9FvtxvXJjTLeN+WhHwK2OederFSQ+7WAyF5/8STTUyBPy8iDPp6cJs 3E/Ehk7VPgR+CZ7CfquhrRVltVCG/A0pt3pwDB8NLuH158+u6n2Tl1OD7LNyllNTRboNuanuz8 4nZAmW0dn+RAkuoIiatH+oCBsDklM7SrPo94db+ytgAjcMyNf4swN4AxPatA6qFbReDoSu/Jjy HkJvNTonkH/azZSPZ59MgFwrfmwnvPsNpLAbfNLWQIJ60Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (snd00013-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.13; dmarc=none header.from=kba.biglobe.ne.jp; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1649303267; bh=Qt0rrI6d7s7ob0hi+7205j5UZTNKI50L8BLPzDxHbHA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Message-ID:In-Reply-To:To:References:Date:Subject: MIME-Version:Content-Transfer-Encoding:Content-Type:From:DKIM-Signature; b=PZTwE5YhkSlBZsaKm4kIk4yS3lI4OJGaFYfJyqTMzQF9LGavp+vSVr6lho2+DWFNtYRccDhiIb 2JztR7UfnGvsEwEhR0v9juu6R1ycAl4zopu113JHmJKz71YXz8w4bSXkYtesqmZGkILezAkmtC Nc3SD06GafyNKdPFk+qSIm7lzzVnQ5OUqUtkUmfoeHJtVrsFGAigmLMYaHd+Dwue31MDluQoW/ Q1+7DQ8IFqkIslcmodIn9zicPM0ewstIsq1xKewCknwItWWhq+54rPfJEGBjDeQ2v03R31rNqM DCBB2tG7MUPPP08nbA8rzhvUCoAJIgUmgFTFsGoO2emOXQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-Id:In-Reply-To:To:References: Date:Subject:Mime-Version:Content-Transfer-Encoding:Content-Type:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=8u8KtdscPXnEnnzKEU5RutGhc8m1XJZrB/bZUK5VP/M=; b=TM0pf/HbaGpWFhyaCe2xIkQcPS Z8TTltFt7NPyN894hWPeu9bPobCjbPN6VbEo5l/YMxtLUSKuqMKrGYSDSjdJhXMjyWplWEgKhuto7 Nwvww14br9CJL0jznirsHDtkMxD1LpF1m38MswiaFGdYz52Izjt1nXmYT0u/Ji6n/uTqKC+6EbFCd /1E4eoKYp4ohxiusWmsnOBkQezLQGrIj2qSCkl9s6Q+sxCKM3vTF7mrtu/EdP1dFtxE1SBoLpb8mp D3iptMMBidBgG0RD59W7dlYcxuU/KltNGkPCl0V1ZOmA6SlTwywygFTjGzXsBTg/iUoN8xSK/D+YH 8KFlGuLA==; Received: from authenticated user by zero.zsh.org with local id 1ncJ7Z-00050G-8n; Thu, 07 Apr 2022 03:47:45 +0000 Authentication-Results: zsh.org; iprev=pass (snd00013-bg.im.kddi.ne.jp) smtp.remote-ip=27.86.113.13; dmarc=none header.from=kba.biglobe.ne.jp; arc=none Received: from snd00013-bg.im.kddi.ne.jp ([27.86.113.13]:52513 helo=dfmta0009.biglobe.ne.jp) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1ncJ7G-0004ey-9B; Thu, 07 Apr 2022 03:47:28 +0000 Received: from mail.biglobe.ne.jp by omta0009.biglobe.ne.jp with ESMTP id <20220407034718796.JNUN.128985.mail.biglobe.ne.jp@biglobe.ne.jp> for ; Thu, 7 Apr 2022 12:47:18 +0900 From: Jun T Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: Hang in E01 due to zpty on OpenBSD Date: Thu, 7 Apr 2022 12:47:18 +0900 References: <4BCAE950-2D78-415A-88C3-8362946DC74C@kba.biglobe.ne.jp> To: zsh-workers@zsh.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.104.21) X-Biglobe-Sender: takimoto-j@kba.biglobe.ne.jp X-Seq: 50010 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > 2022/04/06 21:53, Matthew Martin wrote: > > I'd prefer something like the below where it's a feature test instead of > an OS test. I was thinking that we should better minimize the possible side effects just before the new release. If we use your patch (with some fixes) openpty() will be used on ALL systems (Linux, other BSDs and macOS, ...) if it is available. Is this what you want to achieve? It may work but we need to test on lots of systems. > diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c (snip) > +#elifdef USE_DEV_PTMX #elif defined(USE_DEV_PTMX) > -#elif defined(__OpenBSD__) > - static char char1[] = "pqrstuvwxyzPQRST"; > - static char char2[] = "0123456789" > - "abcdefghijklmnopqrstuvwxyz" > - "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; I think we need to keep this in case openpty() is not available on OpenBSD. > diff --git a/configure.ac b/configure.ac (snip) > +AC_MSG_CHECKING([for openpty]) > +openpty=no We need to call AC_SEARCH_LIBS(openpty, util) here to add -lutil to LIBS. Otherwise the following two AC_LINK_IFELSE() fail and openpty() will never be used.