Re: [PATCH] _pgrep: simplify the processing of '->state' actions

[Jun T <takimoto-j@kba.biglobe.ne.jp>]

> 2018/07/20 4:44, dana <dana@dana.is> wrote:
> 
> On 19 Jul 2018, at 05:06, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>> -# - We assume that Linux systems use procps-ng — specifically, procps-ng >=3.3.4
>> +# - We assume that Linux systems use procps-ng - specifically, procps-ng >=3.3.4
> 
> Would you guys prefer that i not use em dashes in source comments?

Could you please use only 7bit ASCII?
It sometimes happens that I need to use vanilla vi without multibyte
support (e.g., testing on a minimal install of BSD's).

Em dash is especially problematic because it is one of the characters
with "East Asian Ambiguous Width"; how it is displayed depends on the
setting of the terminal and/or font.


> On 19 Jul 2018, at 05:06, Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>> -  '-J+[match only on specified project IDs]: :->projid'
> 
> I'm not sure about moving this. I mean it'll work either way, but why make this
> a special case? Why not also break out -z?

I just wanted to make sure that the '(projid)' part of the case
statements is called only on Solaris because 'ps -o project' would not
work on other OS's.