From: Nikolai Weibull <now@bitwi.se>
To: "Benjamin R. Haskell" <zsh@benizi.com>
Cc: Aaron Schrab <aaron@schrab.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Add completion for help subcommand
Date: Thu, 26 Aug 2010 09:55:39 +0200 [thread overview]
Message-ID: <AANLkTi=y_z0MEtVGi02AqhDTR5hgi2EU-+=6UUu2kGe0@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.01.1008252311460.4535@hp>
On Thu, Aug 26, 2010 at 05:29, Benjamin R. Haskell <zsh@benizi.com> wrote:
> On Thu, 26 Aug 2010, Nikolai Weibull wrote:
>
>> On Sat, Aug 21, 2010 at 14:21, Aaron Schrab wrote:
>>
>> Seems fine except for this:
>>
>> > + local formats='(--info -i --man -m --web -w)'
>>
>> Although this is sort of nice it doesn’t follow the style of this or
>> other completion files, so please write out the whole list in each
>> line.
> It's just visual clutter. Is there a particular reason not to use a
> variable?
Perhaps. The common pattern I saw when I began writing completion functions was
( --b --c)--a
(--a --c)--b
(--a --b )--c
I’d really appreciate some kind of vote or input on this. If we
decide on using variables they should be used throughout.
next prev parent reply other threads:[~2010-08-26 8:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 12:21 Aaron Schrab
2010-08-25 22:16 ` Nikolai Weibull
2010-08-26 3:29 ` Benjamin R. Haskell
2010-08-26 7:55 ` Nikolai Weibull [this message]
2010-08-30 16:43 ` Bart Schaefer
2010-08-30 18:59 ` Nikolai Weibull
2010-08-31 6:57 ` Bart Schaefer
2010-08-27 0:20 ` Aaron Schrab
2010-08-27 8:29 ` Nikolai Weibull
2010-08-27 23:18 ` Aaron Schrab
2010-08-27 23:43 ` Nikolai Weibull
2010-08-28 0:51 ` Aaron Schrab
2010-08-28 7:54 ` Nikolai Weibull
2010-08-28 14:16 ` Aaron Schrab
2010-08-28 14:24 ` Nikolai Weibull
2010-12-02 0:44 ` Aaron Schrab
2010-12-04 18:10 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=y_z0MEtVGi02AqhDTR5hgi2EU-+=6UUu2kGe0@mail.gmail.com' \
--to=now@bitwi.se \
--cc=aaron@schrab.com \
--cc=zsh-workers@zsh.org \
--cc=zsh@benizi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).