From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28205-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 22532 invoked by alias); 26 Aug 2010 08:21:12 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28205
Received: (qmail 13218 invoked from network); 26 Aug 2010 08:21:09 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 74.125.83.171 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:sender:received
         :in-reply-to:references:date:x-google-sender-auth:message-id:subject
         :from:to:cc:content-type:content-transfer-encoding;
        bh=adIxrSZa87ZKD+qAAoflmxp2LXuxEWvlLcaOw38WpoI=;
        b=ZEBZ6L1sH9vGVN/1JM7B0trkii0QqEq91UM1nRKfhNT6IJHDvRDNlwkgMWO7CbtN1k
         BVq+J5Dm7LBMSYF0r8D9ZmbICeOPvjHOnPlui3C0wVpLp5G8EmvgOdVB+KuXBSchOMoN
         v1Zc3c4Z5A0/MamP53DXuCFdfM4zGKnzi5l1A=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=x85upczVK/xFRzpo0Qoqned7Yd1FX/F+53q0jVvr2VuHaxyc5zGmgQ4klt1ZzxyhgL
         TdIxfrxq3endfgXKwerb/dnPFZpvOwUHckh6MpSFkpKV61TU6NesmfOzs/yexc7J/lQ4
         ALbWB5cvFqnPiJdUVUNTKzNFiMGrG2j/u/l/4=
MIME-Version: 1.0
Sender: nikolai.weibull@gmail.com
In-Reply-To: <alpine.LNX.2.01.1008252311460.4535@hp>
References: <1282393263-16767-1-git-send-email-aaron@schrab.com>
	<AANLkTimOcmpFpTrrVMsuvjCR8puCnhoRVsmduci=SP8d@mail.gmail.com>
	<alpine.LNX.2.01.1008252311460.4535@hp>
Date: Thu, 26 Aug 2010 09:55:39 +0200
X-Google-Sender-Auth: CSvQmYK6t228Iy4Ej5VPUQGGdB4
Message-ID: <AANLkTi=y_z0MEtVGi02AqhDTR5hgi2EU-+=6UUu2kGe0@mail.gmail.com>
Subject: Re: [PATCH] _git: Add completion for help subcommand
From: Nikolai Weibull <now@bitwi.se>
To: "Benjamin R. Haskell" <zsh@benizi.com>
Cc: Aaron Schrab <aaron@schrab.com>, zsh-workers@zsh.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 26, 2010 at 05:29, Benjamin R. Haskell <zsh@benizi.com> wrote:
> On Thu, 26 Aug 2010, Nikolai Weibull wrote:
>
>> On Sat, Aug 21, 2010 at 14:21, Aaron Schrab wrote:
>>
>> Seems fine except for this:
>>
>> > + =C2=A0local formats=3D'(--info -i --man -m --web -w)'
>>
>> Although this is sort of nice it doesn=E2=80=99t follow the style of thi=
s or
>> other completion files, so please write out the whole list in each
>> line.

> It's just visual clutter. =C2=A0Is there a particular reason not to use a
> variable?

Perhaps.  The common pattern I saw when I began writing completion function=
s was

(    --b --c)--a
(--a     --c)--b
(--a --b    )--c

I=E2=80=99d really appreciate some kind of vote or input on this.  If we
decide on using variables they should be used throughout.