From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28637-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 389 invoked by alias); 18 Jan 2011 09:59:32 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28637
Received: (qmail 10001 invoked from network); 18 Jan 2011 09:59:30 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.216.43 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:date:message-id:subject:from:to
         :content-type;
        bh=K3VNjGEl+AN49OSwjdQp2wUyfINLBGJqW6mz6Ftd9D8=;
        b=kRwGxATFxarFjdJ7zhDDFka4kJHPs/VB2CF66B6IkRw33wqi1U/tg6U+Rkp2oi79FN
         JJK6ytMv1XhyuSvUdXS2HkxRjRxRTLaya5b/UZfI/wy9UF9G9IybCrPTte/1ZE90Vmys
         oWhngchbL8znWXiqM0ABkKsZE0ESeHvailRgE=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=tt4/lr+79ULGCe7huvzSW8vNmTj4cwUEacIwrbhjkYXFF4wQrrfrjUEID3ijJ/HZ4J
         n0/zW688dXkihtHg5JflzrCjJLk3YT7lSXCmRbDMsqgXBOOyJlR92cicTFDqU5kxUgnv
         9ICFm7zRmCfLXEeRq2LsZlZskSWRLxH4lNcVo=
MIME-Version: 1.0
Date: Tue, 18 Jan 2011 10:37:12 +0100
Message-ID: <AANLkTikOduomu+RT0cEdtkMQ-G=RSW20Li=3OoXcq6Jo@mail.gmail.com>
Subject: [patch] fix a crash in ${:offset:length} substitution
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

Christian Ruppert reported on IRC that ${foo:0:} crashes, ie nothing
after the second colon, here's a fix. With this, it now produces the
diagnostic
zsh: unrecognized modifier


http://mika.l3ib.org/patches/zsh-0:.patch


commit 70bc02156059277bf98265218d11ffd0c80eea48
Author: Mikael Magnusson <mikachu@gmail.com>
Date:   Tue Jan 18 10:34:50 2011 +0100

    Fix crash with ${:0:}

diff --git a/Src/subst.c b/Src/subst.c
index a153f88..377aba8 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -2814,12 +2814,14 @@ paramsubst(LinkList l, LinkNode n, char **str,
int qt, int ssub)
 			zerr("invalid length: %s", check_offset);
 			return NULL;
 		    }
-		    length = mathevali(check_offset);
-		    if (errflag)
-			return NULL;
-		    if (length < (zlong)0) {
-			zerr("invalid length: %s", check_offset);
-			return NULL;
+                    if (check_offset) {
+			length = mathevali(check_offset);
+			if (errflag)
+			    return NULL;
+			if (length < (zlong)0) {
+			    zerr("invalid length: %s", check_offset);
+			    return NULL;
+			}
 		    }
 		}
 		if (horrible_offset_hack) {


-- 
Mikael Magnusson