zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: Add a hook on isearch
Date: Sun, 19 Sep 2010 16:54:48 +0200	[thread overview]
Message-ID: <AANLkTikdVZWhBM5dpNO6kXo+wo0Sz0E0gxNJ_6b0F6jT@mail.gmail.com> (raw)
In-Reply-To: <100918130049.ZM31211@torch.brasslantern.com>

On 18 September 2010 22:00, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sep 18,  6:50pm, Mikael Magnusson wrote:
> }
> } This might make something explode, but it's probably pretty useful.
>
> Maybe it's time for a callhookzle() to go with callhookfunc() and
> runhookdef()?
>
> }      ref:
> } +        if ((cmd = rthingy_nocreate("zle-isearch-update"))) {
> } +           char *args[2];
> } +           args[0] = cmd->nam;
> } +           args[1] = NULL;
> } +           execzlefunc(cmd, args, 1);
> } +           unrefthingy(cmd);
> } +        }
> } +
>
> Seems like there's some global state management that this might not
> be doing with respect to errflag and retflag.

I did something similar on that patch i just linked to on users that
runs on every buffer refresh, and that subtly breaks ^r searching, so
I guess this might have similar problems. Unfortunately (for me) I
just wrote "some static variables" in that mail, so who knows which
ones it actually is... :).

-- 
Mikael Magnusson


  reply	other threads:[~2010-09-19 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-18 16:50 Mikael Magnusson
2010-09-18 20:00 ` Bart Schaefer
2010-09-19 14:54   ` Mikael Magnusson [this message]
2010-09-20  9:02   ` Peter Stephenson
2010-09-23  9:40 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikdVZWhBM5dpNO6kXo+wo0Sz0E0gxNJ_6b0F6jT@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).