From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28275-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 1365 invoked by alias); 19 Sep 2010 14:54:54 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28275
Received: (qmail 4883 invoked from network); 19 Sep 2010 14:54:52 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham
	version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.212.43 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type;
        bh=yasvx32PRvlWZC/C+YddMW9gNml0RHc81/63NqpMxJI=;
        b=GDu4n7PLM7QamKdcOKWJkhBuK8PrLrX17htzbqSalzdUSuXQGv1E2fZiTMdcIouILO
         CJhDRt1Ch6QKOJwb1PbHRWQDj/u3wIloiG/nw36fph0SHOzAggPFdZf2anei89GZxxPy
         o1qwqRNKlMSSUpNZbQXlMhsYrRes8ZpDe0PCw=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=XO4tHVjorfoHRHgWenOrIN2VlRLPPpPVfX/1icyoFo0qgRbZQaeGPOKTsIr76/Pjxx
         ieX9KDNiLo4JTOigrDdJJykeFXqaNc1a1nTl4gD9qsKYMD2wUO92/rkX7S2w5DiMrsd9
         I/RYZhiBybGO3uh/oS1PISTqazYwhhhYi/WL4=
MIME-Version: 1.0
In-Reply-To: <100918130049.ZM31211@torch.brasslantern.com>
References: <AANLkTinEDT7WjY3JFUuMXiN7mHLCYo5OJfsgs2jGW1Sd@mail.gmail.com>
	<100918130049.ZM31211@torch.brasslantern.com>
Date: Sun, 19 Sep 2010 16:54:48 +0200
Message-ID: <AANLkTikdVZWhBM5dpNO6kXo+wo0Sz0E0gxNJ_6b0F6jT@mail.gmail.com>
Subject: Re: Add a hook on isearch
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On 18 September 2010 22:00, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sep 18,  6:50pm, Mikael Magnusson wrote:
> }
> } This might make something explode, but it's probably pretty useful.
>
> Maybe it's time for a callhookzle() to go with callhookfunc() and
> runhookdef()?
>
> }      ref:
> } +        if ((cmd = rthingy_nocreate("zle-isearch-update"))) {
> } +           char *args[2];
> } +           args[0] = cmd->nam;
> } +           args[1] = NULL;
> } +           execzlefunc(cmd, args, 1);
> } +           unrefthingy(cmd);
> } +        }
> } +
>
> Seems like there's some global state management that this might not
> be doing with respect to errflag and retflag.

I did something similar on that patch i just linked to on users that
runs on every buffer refresh, and that subtly breaks ^r searching, so
I guess this might have similar problems. Unfortunately (for me) I
just wrote "some static variables" in that mail, so who knows which
ones it actually is... :).

-- 
Mikael Magnusson