From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-27981-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 12508 invoked by alias); 31 May 2010 09:26:00 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 27981
Received: (qmail 13324 invoked from network); 31 May 2010 09:25:58 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.161.43 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:date:message-id
         :subject:from:to:content-type;
        bh=eR+2KFWD1Bp03cwCCLp49jBYzKZZKE5H/xDZfX9u8FE=;
        b=Jnprqo/EsNvRvZ/LUhOKoLlaS4ggxpkBRqyIJctiBPK+VP+/4A2ju1g5AY4nPzYxee
         P5GtWk4/ncg25JCRh6MCCDAPmXsbT3dLXV6Ec48g4BvTpAdrt3Sx1dnqQF9aM/FWL1uJ
         P+rdQ6Xjg7sKrlPQjL+s+JaXQwIN4ZqW/V2Rk=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=rqng5gswzUZq2Bg/XbV6E1KFufBYWmibM207tmuQAjmPnTqXz1wGFIVtVQ7QGpCFdT
         Cvq5SGcKAthGnHlo6Jl9L/nRw3oDIOaItyOL7y1L3LLnA9BI6rybZrkiG+vutAKjM/tz
         Lqxw30PjsN7Uyj86wKrttF2ckFTkcB6+kKDtw=
MIME-Version: 1.0
Date: Mon, 31 May 2010 11:25:52 +0200
Message-ID: <AANLkTilDNuaXxaRSvX_HuOijsJJdn2jWyl28cw0Z4Kfh@mail.gmail.com>
Subject: e subscript flag
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

I noticed that e is not offered on $a[( tabcompletion, so here's a
patch for that, and this section in the man page:

  To match the value of a parameter literally in a reverse subscript,
rather than as a  pat-
  tern, use `${(q)name}' (see zshexpn(1)) to quote the expanded value.

Would it be better to offer [(e)$name] here? (or both)

diff --git a/Completion/Zsh/Context/_subscript
b/Completion/Zsh/Context/_subscript
index 39bdced..31da97e 100644
--- a/Completion/Zsh/Context/_subscript
+++ b/Completion/Zsh/Context/_subscript
@@ -59,6 +59,7 @@ elif compset -P '\('; then
       '(r R k i I)K[all values where subscript matched by key as pattern]'
       '(r R k K I)i[any one key matched by subscript as pattern]'
       '(r R k K i)I[all keys matched by subscript as pattern]'
+      'e[interpret * or @ as a single key]'
     );;
     (|scalar*)) flags=(
       'w[make subscripting work on words of scalar]'
@@ -66,6 +67,7 @@ elif compset -P '\('; then
       'p[recognise escape sequences in subsequent s flag]'
     );&
     array*) flags=($flags
+      'e[interpret * or @ as a single key and use plain string matching]'
       'n[Nth lowest/highest index with i/I/r/R flag]'
       'b[begin with specified element]'
       '(r R k K i)I[highest index of value matched by subscript]'


-- 
Mikael Magnusson