From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: extended braces syntax, {1..32..-03}
Date: Sun, 5 Dec 2010 20:25:21 +0100 [thread overview]
Message-ID: <AANLkTineOjuWrLv39gS6k7TWU1QTVqYURG0PfJJJXOob@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimm_EMUGdxew_DCQeY=WQ7a78JCX0X670dqeHVA@mail.gmail.com>
On 5 December 2010 20:17, Mikael Magnusson <mikachu@gmail.com> wrote:
> On 5 December 2010 18:25, Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
>> On Sun, 5 Dec 2010 16:41:20 +0100
>> Mikael Magnusson <mikachu@gmail.com> wrote:
>>> This patch adds the syntax {start..end..step} to brace expansion. It
>>> also allows negative numbers to be used (this was allowed when
>>> braceccl was set before, which worked inconsistently). It also fixes
>>> up zero-padding with negative numbers. You can specify zeropadding in
>>> the step, as well as a negative step.
>>>...
>>> Missing still is documentation, but I've had this lying around since
>>> august so I figured I'd post it and see if anyone wants to change
>>> anything first.
>>
>> As long as we [have] tests that pass, it's OK by me.
>>
>> Embarrassingly, there isn't a set of tests for brace expansion at the
>> moment, though a few aspects are covered in other tests. Here is a
>> short 'before' set of tests (I tried it out with the patch applied even
>> though it doesn't test the new features).
>
> Here's a patch that adds documentation and any tests I could think of
> (it includes your patch (you had a typo "pading" on one line)).
Ah, I missed you already committed the tests, here's an incremental patch
http://mika.l3ib.org/patches/zsh-braces-test-docs-incr.patch
--
Mikael Magnusson
next prev parent reply other threads:[~2010-12-05 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 15:41 Mikael Magnusson
2010-12-05 17:25 ` Peter Stephenson
2010-12-05 19:17 ` Mikael Magnusson
2010-12-05 19:25 ` Mikael Magnusson [this message]
2010-12-05 21:32 ` Mikael Magnusson
2010-12-06 21:02 ` Richard Hartmann
2010-12-06 21:04 ` Mikael Magnusson
2010-12-06 21:18 ` Richard Hartmann
2010-12-07 11:40 ` Peter Stephenson
2010-12-06 20:57 ` Richard Hartmann
2010-12-06 21:00 ` Mikael Magnusson
2010-12-06 21:17 ` Richard Hartmann
2010-12-06 21:49 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTineOjuWrLv39gS6k7TWU1QTVqYURG0PfJJJXOob@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).