From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH} define _GNU_SOURCE on Cygwin
Date: Wed, 26 Oct 2016 21:30:26 +0900 [thread overview]
Message-ID: <AC3A6441-80E8-4304-A010-F2A6BAA93929@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20161026105652.GA14865@fujitsu.shahaf.local2>
2016/10/26 19:56, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> The patch causes _XOPEN_SOURCE to no longer be defined, ever.
_GNU_SOURCE is a superset of _XOPEN_SOURCE; it is virtually
equivalent to defining both _BSD_SOURCE and _XOPEN_SOURCE.
> Is this okay for both old and new cygwin? I.e., does this patch work
> for people compiling new zsh on old cygwin?
Sorry, I can't test on older cygwin.
I guess installing older cygwin is not trivial.
Unless someone still has older cygwin can test the patch, what we
can do would be to either go with _GNU_SOURCE (and to see whether
incompatibility with older cygwin comes out or not), or just
continue using the current code, which generates some warnings
but still seems to work fine (the return value of wcwidth() is int,
which is what compiler assumes when no prototype is available).
next prev parent reply other threads:[~2016-10-26 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 10:04 Jun T.
2016-10-26 10:56 ` Daniel Shahaf
2016-10-26 12:30 ` Jun T. [this message]
2016-10-26 19:55 ` Peter A. Castro
2016-10-27 1:34 ` Daniel Shahaf
2016-10-31 6:15 ` Peter A. Castro
2016-11-01 12:11 ` Jun T.
2016-11-01 16:31 ` Peter A. Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC3A6441-80E8-4304-A010-F2A6BAA93929@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).