From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1382 invoked by alias); 26 Oct 2016 13:15:48 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39730 Received: (qmail 4029 invoked from network); 26 Oct 2016 13:15:48 -0000 X-Qmail-Scanner-Diagnostics: from rcpt-mqugw.biglobe.ne.jp by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(133.208.100.2):SA:0(-1.3/5.0):. Processed in 0.583021 secs); 26 Oct 2016 13:15:48 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=RP_MATCHES_RCVD,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: takimoto-j@kba.biglobe.ne.jp X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.208.100.2 as permitted sender) X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH} define _GNU_SOURCE on Cygwin From: "Jun T." In-Reply-To: <20161026105652.GA14865@fujitsu.shahaf.local2> Date: Wed, 26 Oct 2016 21:30:26 +0900 Content-Transfer-Encoding: 7bit Message-Id: References: <9E7FD5B2-061D-4ABE-84A8-A54C844E34BE@kba.biglobe.ne.jp> <20161026105652.GA14865@fujitsu.shahaf.local2> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1878.6) X-Biglobe-Spnum: 60965 2016/10/26 19:56, Daniel Shahaf wrote: > > The patch causes _XOPEN_SOURCE to no longer be defined, ever. _GNU_SOURCE is a superset of _XOPEN_SOURCE; it is virtually equivalent to defining both _BSD_SOURCE and _XOPEN_SOURCE. > Is this okay for both old and new cygwin? I.e., does this patch work > for people compiling new zsh on old cygwin? Sorry, I can't test on older cygwin. I guess installing older cygwin is not trivial. Unless someone still has older cygwin can test the patch, what we can do would be to either go with _GNU_SOURCE (and to see whether incompatibility with older cygwin comes out or not), or just continue using the current code, which generates some warnings but still seems to work fine (the return value of wcwidth() is int, which is what compiler assumes when no prototype is available).