From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH} define _GNU_SOURCE on Cygwin
Date: Tue, 1 Nov 2016 21:11:22 +0900 [thread overview]
Message-ID: <AE5562AA-6551-494E-AB3F-E700BAAA92D1@kba.biglobe.ne.jp> (raw)
In-Reply-To: <alpine.LNX.2.00.1610302212230.6490@ming.fruitbat.org>
On 2016/10/31, at 15:15, Peter A. Castro <doctor@fruitbat.org> wrote:
> I built with Cygwin 1.7.35
Thanks.
> With the proposed patch from Jun, zsh compiles, links and runs the check tests "adequately".
Did you get any "new" warnings when building with the patch?
(new = no warning without the patch)
> I say "adequately" because there were 2 test failures, 5 skipped and 40 successful.
Do the same 2 tests fail if you do not apply the patch?
> As a result, I only applied the change to zsh_system.h, which was successful.
Yes, that is sufficient to test the patch.
Jun
next prev parent reply other threads:[~2016-11-01 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 10:04 Jun T.
2016-10-26 10:56 ` Daniel Shahaf
2016-10-26 12:30 ` Jun T.
2016-10-26 19:55 ` Peter A. Castro
2016-10-27 1:34 ` Daniel Shahaf
2016-10-31 6:15 ` Peter A. Castro
2016-11-01 12:11 ` Jun T. [this message]
2016-11-01 16:31 ` Peter A. Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE5562AA-6551-494E-AB3F-E700BAAA92D1@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).