From: Peter Moore <pmoore@mozilla.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Remove spurious open bracket in zsh man page
Date: Tue, 7 Jul 2020 09:33:57 +0200 [thread overview]
Message-ID: <B03C4BBE-D3C6-499D-9170-AC21FD71532E@mozilla.com> (raw)
In-Reply-To: <20200706234421.3b38540c@tarpaulin.shahaf.local2>
Thanks Daniel! Indeed the log message was incorrect; it was indeed a spurious closing bracket. Thanks for correcting!
Pete
> On 7. Jul 2020, at 01:44, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Pete Moore wrote on Mon, 06 Jul 2020 12:50 +0200:
>> ---
>> Doc/Zsh/metafaq.yo | 1 -
>> 1 file changed, 1 deletion(-)
>
> Thanks! Merged with a changed log message.
>
> Quick question: The patch removes a _closing_ bracket but the log
> message spoke of an _opening_ bracket. Is there a stray opening
> bracket somewhere as well?
>
> For patch submission we prefer email to GitHub. Thanks for covering
> all the bases, though!
>
> Cheers,
>
> Daniel
>
>> diff --git a/Doc/Zsh/metafaq.yo b/Doc/Zsh/metafaq.yo
>> index c123a7cea..e41b88dc5 100644
>> --- a/Doc/Zsh/metafaq.yo
>> +++ b/Doc/Zsh/metafaq.yo
>> @@ -25,7 +25,6 @@ cindex(acquiring zsh by FTP)
>> cindex(availability of zsh)
>> nofill(uref(ftp://ftp.zsh.org/pub/)
>> uref(https://www.zsh.org/pub/))
>> -)
>>
>> The up-to-date source code is available via Git from Sourceforge. See
>> uref(https://sourceforge.net/projects/zsh/) for details. A summary of
>
prev parent reply other threads:[~2020-07-07 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 10:50 Incoming patch for fix to " Pete Moore
2020-07-06 10:50 ` [PATCH] Remove spurious open bracket in " Pete Moore
2020-07-06 23:44 ` Daniel Shahaf
2020-07-07 7:33 ` Peter Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B03C4BBE-D3C6-499D-9170-AC21FD71532E@mozilla.com \
--to=pmoore@mozilla.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).