From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Vimode problem (key press dropping)
Date: Wed, 29 Jul 2015 19:51:00 +0900 [thread overview]
Message-ID: <B709D83B-0F41-42B7-B17D-01D5AB7572CC@kba.biglobe.ne.jp> (raw)
In-Reply-To: <9361.1438161965@thecus.kiddle.eu>
reply to zsh-users, X-Seq: 20356
On 2015/07/29, at 18:26, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
>
> Question to -workers subscribers: how should we address this in the
> defaults?
In zle_keymap.c, near line 1493, timeout is set only if
(f != t_undefinedkey). But ESC is an undefinedkey in vicmd keymap,
and the timeout remains to be zero even if ispfx is true.
I guess the timeout should always be set if ispfx is true.
Maybe something like the following?
diff --git a/Src/Zle/zle_keymap.c b/Src/Zle/zle_keymap.c
index d355f41..f1fa912 100644
--- a/Src/Zle/zle_keymap.c
+++ b/Src/Zle/zle_keymap.c
@@ -1495,14 +1495,14 @@ getkeymapcmd(Keymap km, Thingy *funcp, char **strp)
func = f;
str = s;
lastc = lastchar;
-
- /* can be patient with vi commands that need a motion operator: *
- * they wait till a key is pressed for the movement anyway */
- timeout = !(!virangeflag && !region_active && f && f->widget &&
- f->widget->flags & ZLE_VIOPER);
}
if (!ispfx)
break;
+
+ /* can be patient with vi commands that need a motion operator: *
+ * they wait till a key is pressed for the movement anyway */
+ timeout = !(!virangeflag && !region_active && f && f->widget &&
+ f->widget->flags & ZLE_VIOPER);
}
if(!lastlen && keybuflen)
lastlen = keybuflen;
next parent reply other threads:[~2015-07-29 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5d9984411ba10dee4321a408e2763317@riseup.net>
[not found] ` <9361.1438161965@thecus.kiddle.eu>
2015-07-29 10:51 ` Jun T. [this message]
2015-07-29 14:14 ` Oliver Kiddle
2015-07-29 15:31 ` Jun T.
2015-07-29 15:22 ` Bart Schaefer
2015-08-10 12:34 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B709D83B-0F41-42B7-B17D-01D5AB7572CC@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).