From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14694 invoked by alias); 15 Jan 2018 11:07:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42286 Received: (qmail 29265 invoked by uid 1010); 15 Jan 2018 11:07:52 -0000 X-Qmail-Scanner-Diagnostics: from mail-it0-f45.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.214.45):SA:0(-1.9/5.0):. Processed in 8.913222 secs); 15 Jan 2018 11:07:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0MbvNVjuoyuXT64Gq1azV7y1QT4Z5IG6iNHBkc5wcDo=; b=loj8OYs7yy80SjLa5TP0cX44jyNNEIjHENhcmhseApWWnuDIpwW1BVcHxobvgfeAj7 4v2cvl9p0UJwLK0CCkW+XOLCz2YoCUQGvpAaMJlh+ynvli6lOrnNmHyqWqIoG8rU+BN1 N+zRiiusQKRSvr/vtE0CFJTZIwCczqlzImFfXIOW1dzQ8mG3pIYNUmDt2ABUgbHLSQG1 /sz+WnZUJAF72b/hxn1udPpRPVruItrupXofkEt2bbN6M+4rLUODc2IQx4fepb/UaMZZ 8AAWAdx3U30jNnzDyFpXBHicsEIYmfndxc/6rorp10xHqkz23ty6jV2QUmBHZMy9+G9p JVww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0MbvNVjuoyuXT64Gq1azV7y1QT4Z5IG6iNHBkc5wcDo=; b=GkpYZu7wKQjxIkbP9rcWeKDGn8wub9/5Zwp/ytlj9OoicrawKAT5vhyffRbM8QPemz 1S/QW0NlDzJqFv0HwztD6RgUDql0xiWTLIcJIBuKjFxLRcN9dM0v9A+uqZXywaeP5/WX tn7WGMg1Yn+CtD3+nhOPtsvRTThAi4n6xxReBX34k+5k86WyqLUtSB9m6wEpnUhQ3WDC wp/sqLg5g+9Mav7SUeYtBHNB3DTfO+GX/9sDlWcoLemFrX8WretCm8rHtGYEgnjAdO5Z SO1cNsrFfD4BdXlMCkQG9y1ZD6gvHPMIqTemc0QrTW6QxQyMG9tB3HRY09jU/ceBn/15 yogQ== X-Gm-Message-State: AKwxytdtEDjmNidKCJvq3ix3aXqbsvZrIKbyeOBscl5eY8c+dJsgn610 DX4z+HrhohRD49HyInmq07lUSg== X-Google-Smtp-Source: ACJfBoto1RcgM6rMn+4zfeZyBWQVH7G2Ugf5snmzhuE2jyTB1Pi0chGX0F0k+/fD7RM18E6zOmxVVA== X-Received: by 10.36.39.215 with SMTP id g206mr6771279ita.17.1516014460685; Mon, 15 Jan 2018 03:07:40 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH 0/1] prompt: Fix an off-by-one in the overf check in countpromt. From: dana In-Reply-To: <20180115103558.1258-1-warepire.ml@gmail.com> Date: Mon, 15 Jan 2018 05:07:39 -0600 Cc: zsh-workers@zsh.org, Warepire Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180115103558.1258-1-warepire.ml@gmail.com> To: warepire.ml@gmail.com X-Mailer: Apple Mail (2.3273) On 15 Jan 2018, at 04:35, warepire.ml@gmail.com wrote: >Additionally to the commit message: I have only managed to test this >for my own use-cases, which is a very narrow subset of tests. FYI, if it's any help, i tested this in the following, too: * Terminal.app * iTerm2 * Alacritty I used a multi-line prompt where the top line had a length of COLUMNS, = COLUMNS + 1, or COLUMNS - 1. I tried both with single-byte characters only and = with mixed single/multi-byte characters. Replication: % zle-line-init() zle reset-prompt % zle -N zle-line-init % PROMPT=3D${(l<$COLUMNS>):-}$'\n%~ %# ' = abcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcab= cabc ~ % echo foo Current behaviour: The echo output is swallowed up by the next prompt. Patched behaviour: The echo output remains unmolested. PS: When i was testing it i had changed the comparison in both places; = as mentioned, the patch as submitted only changes the first one. dana