zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Zsh workers <zsh-workers@zsh.org>
Cc: Oliver Kiddle <okiddle@yahoo.co.uk>
Subject: Re: [PATCH] Completion: Improve _man
Date: Sun, 10 Jun 2018 09:02:37 -0500	[thread overview]
Message-ID: <B8768D9A-07D9-46D8-B0C0-CE78FBE9079C@dana.is> (raw)
In-Reply-To: <17923.1528636054@thecus>

On 10 Jun 2018, at 08:07, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
>Is this the line where you removed * from:
> dirs=( $^_manpath/(sman|man|cat)${^sects}*/ )
>
>I think I've seen systems with directories named man1.Z/cat1.Z etc.
>HP/UX perhaps. Perhaps also locales have occured such as man3f.fi_FI
>I suspect the * was to handle something like that rather than for the
>undesirable functionality you describe.

It is, and that would make sense. If that is indeed the reason the pattern was
there, maybe it would be more accurate like this?

  dirs=( $^_manpath/(sman|man|cat)${^sects}(|.*)/ )

But then i think we'd need to strip the .* back out afterwards too.

On 10 Jun 2018, at 08:07, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
>It looks like the sections will be changing with Solaris 11.4:
>
>https://blogs.oracle.com/solaris/normalizing-man-page-section-numbers-in-solaris-114-v2

lol. Well... that's time well spent then.

Also i guess that change is going to introduce another issue like the current
_shutdown function has where relying on OSTYPE alone produces false positives
(because all of the Solaris variants report solaris2.11 or whatever, but some of
them are quite different from each other — now they'll have different man-page
structures).

>This results in all sections for which we don't have a description
>getting an empty description. The descriptions that we have are then
>pushed right over to the right like this:

Yeahhh. I identified that problem at some point, but then i forgot about the
actual implications. I like the _describe solution.

I'll try to fix any remaining issues with this later. Thanks!

dana


  reply	other threads:[~2018-06-10 14:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10  6:06 dana
2018-06-10 13:07 ` Oliver Kiddle
2018-06-10 14:02   ` dana [this message]
2018-06-11 10:48     ` [PATCH] Completion: Improve _man (2) dana
2018-06-14  9:50       ` Daniel Shahaf
2018-06-14 10:20         ` dana
2018-06-15 13:59           ` [PATCH] Completion: Improve _man (3) dana
2018-06-15 14:05             ` Daniel Shahaf
2018-06-15 14:21               ` dana
2018-06-15 14:39                 ` Mikael Magnusson
2018-06-15 14:55                   ` Daniel Shahaf
2018-06-15 15:14                     ` dana
2018-06-15 15:36                       ` Peter Stephenson
2018-06-15 17:27                     ` Mikael Magnusson
2018-06-15 14:47                 ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B8768D9A-07D9-46D8-B0C0-CE78FBE9079C@dana.is \
    --to=dana@dana.is \
    --cc=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).