From: dana <dana@dana.is>
To: Doron Behar <doron.behar@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Add completion for zathura.
Date: Sun, 1 Jul 2018 14:06:57 -0500 [thread overview]
Message-ID: <BADE664B-63FB-43FF-839D-54A6D6BA9B94@dana.is> (raw)
In-Reply-To: <20180701171158.6uzs27ooafm4pk42@NUC.doronbehar.com>
On 1 Jul 2018, at 12:11, Doron Behar <doron.behar@gmail.com> wrote:
>Hey guys, just reminding you there's a patch here ready for your
>comments / merge.
Some things i noticed (disregard anything that's too nit-picky i guess):
On 13 Jun 2018, at 11:31, doron.behar@gmail.com wrote:
>+_zathura_files(){
* I don't think you want to quote the variables in your for loop; whenever
they're empty, you'll be looking for files matching /*.so
* However, you maybe *do* want to apply (Q) to the opt_args values, since
they're taken 'raw' from the command line, and quoting file paths is a very
common thing that people do
* Is the first check really supposed to be [[ -z $plugin_files ]] rather than
-n? It seems like it's going to immediately break out of the loop unless
_arguments found -p (or there are random shared libs in /)
* Should /usr/lib have precedence over /usr/local/lib? It's not typical
* plugins_dir and pf need made local
On 13 Jun 2018, at 11:31, doron.behar@gmail.com wrote:
>+_arguments \
* I think this could use -s and -S
* Since Zathura uses GLib's dumb option parser, i think (?) it's right that
these are given in -o,--opt= form rather than the usual -o+,--opt=. Might want
to make a note tho; i always double-take when i see that personally
* The descriptions for the options are inconsistently worded (some are verb
phrases, some use the indicative mood, some are just describing the argument)
and they don't conform to the usual capitalisation conventions
* Some of the optarg descriptions aren't that helpful ('number')
dana
next prev parent reply other threads:[~2018-07-01 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 16:31 doron.behar
2018-07-01 17:11 ` Doron Behar
2018-07-01 19:06 ` dana [this message]
2018-07-13 12:29 ` Doron Behar
2018-07-13 16:55 ` dana
2018-07-13 19:53 ` Doron Behar
2018-07-13 19:52 doron.behar
2018-07-16 17:24 ` Doron Behar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BADE664B-63FB-43FF-839D-54A6D6BA9B94@dana.is \
--to=dana@dana.is \
--cc=doron.behar@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).