From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2286 invoked by alias); 1 Jul 2018 19:07:04 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43125 Received: (qmail 29310 invoked by uid 1010); 1 Jul 2018 19:07:04 -0000 X-Qmail-Scanner-Diagnostics: from mail-io0-f181.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.223.181):SA:0(-1.9/5.0):. Processed in 1.943 secs); 01 Jul 2018 19:07:04 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIMWL_WL_MED,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1J92zjmqXud2MKC0RnuEJ/fiIF9wZOk9sQURzVsG2lQ=; b=kdG6r4TZHmq/bMPjCPVHQ+Qs0xga31feWi9jWZwEE0QHntFKnwdb6IosjAqfWr+t7F YSXwqh8VqrOV0pzzMTXx+360lVlo+xAsWa297YPjLIVoTS/YCQAxqyRhRAiM1dwRgPch ZlnKVFctypc1UVXE0DHYifF5b1cTXbf7MaBSwXsfHigkZOho0LR/2ec811jrGJ3PZA+u sK+pA8UDq1rSfrK3Teh8kqrqUxb3X0DDY5iitUjIYLmSg26XtlGMTVg5qDvu+A2u1UxN S0JhQ1y45IqJI71gE52pxC4W426pUYJVrxaS6DT71/zQrL0Tifx5DwPzvzgwlfirzSyc bxtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1J92zjmqXud2MKC0RnuEJ/fiIF9wZOk9sQURzVsG2lQ=; b=m3/eMVMYgY2Yci+BknXym1+t/pT0c9/uwjg8DZYerUTKRABrJL1gScOUfHj7u7CnPb ey7JaPZL3T9XzDiPyVNe1tZWGYkR4vrzzgM9Di/JZmvLzNLvrV8V0+z1e9oIi8wLsImS LBmeCRcLCfHlKU/bJLe875iuEzROf/CMbHS9QXCE9cmOQORNt0wrO1+WhwbxLP6ZCtlh j2SRMfuUnPRL9UPL2+mEZFEtS+VTNZGOfcZsM33TrEhM31IuACeKawJ+P4KmhAeB8rD5 7tTyABjO0Le0ai37a8B76VLImnbHRRJ14roQViefzyBffizxZC8JnrTefwsrXpbuhcjT wMxg== X-Gm-Message-State: APt69E2qL+54l0xy4mG/RVJW0lIItJ7RgUI1Gmmjg63WnetXlH4Ox9HX 4BhMnH/THHiXoMwj+R7uow1Fvw== X-Google-Smtp-Source: AAOMgpfyPeW72ZKjRUHQayEWe/65OOeI49Tyhe2nR3DrJlYO2glzE6/FpYm7wn6D/MWQoKJd7awfHw== X-Received: by 2002:a6b:1c07:: with SMTP id c7-v6mr19814762ioc.298.1530472019660; Sun, 01 Jul 2018 12:06:59 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: [PATCH] Add completion for zathura. From: dana In-Reply-To: <20180701171158.6uzs27ooafm4pk42@NUC.doronbehar.com> Date: Sun, 1 Jul 2018 14:06:57 -0500 Cc: zsh-workers@zsh.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180613163152.28843-1-doron.behar@gmail.com> <20180701171158.6uzs27ooafm4pk42@NUC.doronbehar.com> To: Doron Behar X-Mailer: Apple Mail (2.3445.8.2) On 1 Jul 2018, at 12:11, Doron Behar wrote: >Hey guys, just reminding you there's a patch here ready for your >comments / merge. Some things i noticed (disregard anything that's too nit-picky i guess): On 13 Jun 2018, at 11:31, doron.behar@gmail.com wrote: >+_zathura_files(){ * I don't think you want to quote the variables in your for loop; = whenever they're empty, you'll be looking for files matching /*.so * However, you maybe *do* want to apply (Q) to the opt_args values, = since they're taken 'raw' from the command line, and quoting file paths is a = very common thing that people do * Is the first check really supposed to be [[ -z $plugin_files ]] rather = than -n? It seems like it's going to immediately break out of the loop = unless _arguments found -p (or there are random shared libs in /) * Should /usr/lib have precedence over /usr/local/lib? It's not typical * plugins_dir and pf need made local On 13 Jun 2018, at 11:31, doron.behar@gmail.com wrote: >+_arguments \ * I think this could use -s and -S * Since Zathura uses GLib's dumb option parser, i think (?) it's right = that these are given in -o,--opt=3D form rather than the usual -o+,--opt=3D. = Might want to make a note tho; i always double-take when i see that personally * The descriptions for the options are inconsistently worded (some are = verb phrases, some use the indicative mood, some are just describing the = argument) and they don't conform to the usual capitalisation conventions * Some of the optarg descriptions aren't that helpful ('number') dana