From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Peter Stephenson <Peter.Stephenson@csr.com>,
"Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Next zsh release
Date: Thu, 19 May 2011 18:49:20 +0200 [thread overview]
Message-ID: <BANLkTi=5RdvxNn3047R6+AvuFQKJUAYJJg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinen5KwzxSoPtVd9=TG9AATvZFYkw@mail.gmail.com>
On 19 May 2011 17:17, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Thu, May 19, 2011 at 7:55 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
>> PATCH: Remove some unused assignments/checks noticed by clang
>
> I'm really leery of this one. There were at least two cases someone
> spotted where the changes were wrong, weren't there? Seems like a bad
> thing to gamble on right before a release.
While trying to build statically to double check these changes, I
noticed this happens when building zftp statically:
In file included from zftp.c:54:
zftp.mdh:5:1: warning: "boot_" redefined
In file included from zftp.c:53:
tcp.mdh:5:1: warning: this is the location of the previous definition
and so on for all those functions. It seems to work though, since the
files are included in the correct order.
--
Mikael Magnusson
next prev parent reply other threads:[~2011-05-19 16:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 13:02 Peter Stephenson
2011-05-19 14:55 ` Mikael Magnusson
2011-05-19 15:07 ` Peter Stephenson
2011-05-19 20:15 ` Mikael Magnusson
2011-05-19 15:17 ` Bart Schaefer
2011-05-19 16:49 ` Mikael Magnusson [this message]
2011-05-19 17:53 ` Mikael Magnusson
2011-05-19 18:17 ` Wayne Davison
2011-05-19 18:35 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=5RdvxNn3047R6+AvuFQKJUAYJJg@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=Peter.Stephenson@csr.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).