zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Slowness issue with git completion
Date: Wed, 27 Apr 2011 07:55:23 -0700	[thread overview]
Message-ID: <BANLkTi=BkruWOqyKR-a_aeGS8+npiOsibw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimmw3+nWyYS27MzDm-z-rFCT2yxaQ@mail.gmail.com>

On Wed, Apr 27, 2011 at 5:51 AM, Nikolai Weibull <now@bitwi.se> wrote:
> On Wed, Apr 27, 2011 at 06:19, Bart Schaefer <schaefer@brasslantern.com> wrote:
>
>> I suspect that if someone undertook to rewrite __git_files_relative
>
> Let’s instead remove it.

So much the better, now it's using only git operations.  Those who are
more active git-users than I should do the reviewing, though.

> Also, Bart, supplying -f to _multi_parts here doesn’t seem to have any
> effect on match highlighting.  Directories are shown the same as
> files.  This was something I asked about a long time ago that we were
> going to look at at a later date.  Perhaps that date has come?

See http://www.zsh.org/mla/workers//2010/msg00853.html (just so I can
be embarrassed again about the messed-up subject line).  I don't think
there's anything helpful to be done about _multi_parts, the coloring
is applied by the compadd builtin and the information it needs in
order to decide that something is a file is incompatible with the way
_multi_parts breaks up the strings.  Even if compadd could be called
the correct way, it will only color local stat-able files.

I hesitate to suggest this because it will be a lot of work for a
little shine, but you could try asserting a local value for ZLS_COLORS
in __git_files populated with pattern forms that produce the correct
coloring.


  reply	other threads:[~2011-04-27 14:55 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 18:26 Felipe Contreras
2011-04-26 18:43 ` Frank Terbeck
2011-04-26 19:06   ` Nikolai Weibull
2011-04-26 20:10     ` Frank Terbeck
2011-04-26 20:23   ` Felipe Contreras
2011-04-26 20:34     ` Mikael Magnusson
2011-04-26 20:57       ` Felipe Contreras
2011-04-26 20:59         ` Mikael Magnusson
2011-04-26 21:10           ` Felipe Contreras
2011-04-26 21:13             ` Mikael Magnusson
2011-04-26 21:35               ` Felipe Contreras
2011-04-26 22:03                 ` Nikolai Weibull
2011-04-26 22:25                   ` Felipe Contreras
2011-04-26 23:14                     ` Benjamin R. Haskell
2011-04-27  7:01                       ` Benjamin R. Haskell
2011-04-27  1:52                     ` gi1242+zsh
2011-04-27  6:11                     ` Nikolai Weibull
2011-04-27  8:30                       ` Felipe Contreras
2011-04-27  8:47                         ` Frank Terbeck
2011-04-27  9:06                           ` Felipe Contreras
2011-04-27 10:15                         ` Nikolai Weibull
2011-04-27 10:42                           ` Felipe Contreras
2011-04-27 11:14                             ` Nikolai Weibull
2011-04-27  4:19                 ` Bart Schaefer
2011-04-27  6:13                   ` Nikolai Weibull
2011-04-27 12:51                   ` Nikolai Weibull
2011-04-27 14:55                     ` Bart Schaefer [this message]
2011-04-27 18:36                       ` Nikolai Weibull
2011-04-30 14:37                     ` Simon Ruderich
2011-04-30 15:00                       ` Simon Ruderich
2011-05-02  9:59                       ` Nikolai Weibull
2011-05-03 13:59                         ` Nikolai Weibull
2011-04-26 21:52         ` Benjamin R. Haskell
2011-04-26 22:04           ` Felipe Contreras
2011-04-26 22:35             ` Benjamin R. Haskell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=BkruWOqyKR-a_aeGS8+npiOsibw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).