From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25655 invoked by alias); 27 Apr 2011 14:55:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29092 Received: (qmail 8435 invoked from network); 27 Apr 2011 14:55:31 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts) MIME-Version: 1.0 In-Reply-To: References: <87liyw7t0o.fsf@ft.bewatermyfriend.org> <110426211951.ZM4200@torch.brasslantern.com> Date: Wed, 27 Apr 2011 07:55:23 -0700 Message-ID: Subject: Re: Slowness issue with git completion From: Bart Schaefer To: zsh-workers@zsh.org Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On Wed, Apr 27, 2011 at 5:51 AM, Nikolai Weibull wrote: > On Wed, Apr 27, 2011 at 06:19, Bart Schaefer = wrote: > >> I suspect that if someone undertook to rewrite __git_files_relative > > Let=92s instead remove it. So much the better, now it's using only git operations. Those who are more active git-users than I should do the reviewing, though. > Also, Bart, supplying -f to _multi_parts here doesn=92t seem to have any > effect on match highlighting. =A0Directories are shown the same as > files. =A0This was something I asked about a long time ago that we were > going to look at at a later date. =A0Perhaps that date has come? See http://www.zsh.org/mla/workers//2010/msg00853.html (just so I can be embarrassed again about the messed-up subject line). I don't think there's anything helpful to be done about _multi_parts, the coloring is applied by the compadd builtin and the information it needs in order to decide that something is a file is incompatible with the way _multi_parts breaks up the strings. Even if compadd could be called the correct way, it will only color local stat-able files. I hesitate to suggest this because it will be a lot of work for a little shine, but you could try asserting a local value for ZLS_COLORS in __git_files populated with pattern forms that produce the correct coloring.