zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: (rfc) HIST_FIND_DUPS option
Date: Mon, 9 May 2011 16:51:24 -0700	[thread overview]
Message-ID: <BANLkTi=EypRYYfDn9JjBxhB5aHZWkf8VsA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinNiXnaHb2mWJhWOKZoqoE9U1Bhcw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Mon, May 9, 2011 at 3:09 PM, Mikael Magnusson <mikachu@gmail.com> wrote:

> I am currently unsure why unsetting HIST_FIND_NO_DUPS doesn't have this
> behaviour already. Possibly it only finds the same line after finding
> another line in between that also matches the search


Exactly.  Under normal circumstance, if the user has rejected a particular
line as not being one that they want to run, showing them the same line
isn't usually very useful to them (and may indeed be confusing).

I don't particularly like the HIST_FIND_DUPS option.  If you named it
HIST_FIND_ALL_DUPS I'd like it a bit better, but I do wonder if there isn't
a better solution to help you solve this particular search idiom (one where
you're really searching not just for a line, but for a set of lines).  For
instance, it would be interesting to be able to ask zsh to show a line or
two of context following the line as you visit each matching line.  In such
a search, it would make a lot of sense to show the user another identical
line that has differing context, so that would be the default.

..wayne..

  reply	other threads:[~2011-05-09 23:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-09 22:09 Mikael Magnusson
2011-05-09 23:51 ` Wayne Davison [this message]
2011-05-10  0:03   ` Mikael Magnusson
2011-05-10  5:08     ` Wayne Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=EypRYYfDn9JjBxhB5aHZWkf8VsA@mail.gmail.com' \
    --to=wayned@users.sourceforge.net \
    --cc=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).