From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10862 invoked by alias); 26 Apr 2011 20:57:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29062 Received: (qmail 16904 invoked from network); 26 Apr 2011 20:57:12 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.161.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=QbuHA1qyDaYQIRuyl1BXfDbSBcRMQxExm6LQcGdx97w=; b=ogmhY00pemPDO8UaHm27bC5aRpGp9RUV3/RKu5lP2O2ANVNHMvbYdtqQ5rtZDl+kbp Z/3QCEFsqTKfPYEKWRvFP9cRVq9srqVFHDrbxYVGKuH8MFUzrpZnPSu/onP7gzzSPNf9 BnaSJRDgJm9vcd+LP3x4N1JEIAAiUvOJLUSIQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YwRvu1AcVvxKtHvBKXk9cX07HMOx0mIErlglKBQRcYHTfqUrQUi8cIQSdAB7nYnJLj dDHma9Sg701F9hvWV+D/rTsqBcj+t+k9d4+3qONUra5DH5YQl1AK4hdcWLC5bAHSNBcE VarufXdISsY9mOUR4FJDKF2eZCQjL83jdOzVQ= MIME-Version: 1.0 In-Reply-To: References: <87liyw7t0o.fsf@ft.bewatermyfriend.org> Date: Tue, 26 Apr 2011 23:57:05 +0300 Message-ID: Subject: Re: Slowness issue with git completion From: Felipe Contreras To: Mikael Magnusson Cc: Frank Terbeck , zsh-workers@zsh.org, Nikolai Weibull Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2011 at 11:34 PM, Mikael Magnusson wrot= e: > On 26 April 2011 22:23, Felipe Contreras wro= te: >> On Tue, Apr 26, 2011 at 9:43 PM, Frank Terbeck = wrote: >>> Felipe Contreras wrote: >>>> It's very easy to reproduce: >>>> % git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/lin= ux-2.6.git >>>> linux >>>> % cd linux >>>> % git log v >>>> >>>> It will take a looong time to figure out anything, specially if not >>>> cached. I think I recall investigating the issue and finding that it's >>>> looking for *all* the files in the git repo. >>> >>> Well yes. This is a known issue. >>> >>> I'm fairly sure that this is due to _multi_parts, which probably doesn'= t >>> scale for jobs like that. =C2=A0I once gave rewriting all that a shot a= nd >>> ended up with a number of helpers for each "type" of file etc. (like >>> modified or ignored files). =C2=A0While they were significantly quicker= than >>> the current code, they were probably still full of bugs and >>> shortcomings. Also, I would have had to rewrite *large* parts of the >>> rest of the completion, which would have been a *major* undertaking. >>> >>> In short: It's a known issue and it's very hard to fix (if only because >>> it is a *lot* of work). >> >> Here's a quick solution: don't try to list files. If I want to list >> files, I would use '-- '. And in fact, that's exactly what the bash >> completion does. > > git accepts files with or without a -- So? >> Moreover, why do you want to be smarter than git? There are ways to >> ask git precisely what we want: list the contents of certain tree-ish >> on-demand. And in fact, that's exactly what the bash completion does: >> >> time git ls-tree HEAD -- (0m0.005s) >> time git ls-tree HEAD -- drivers/ (0m0.007s) > > git ls-tree doesn't allow you to filter the output files by 'changed', > 'new', 'unknown' etc etc. So? >> Seriously, this is very annoying. > > This type of comment is not productive. Well, I have been waiting a long time for this to be fixed, if this is a known issue, and you already know it's very annoying, and there's no plan to fix it, I can only assume that you don't care. So I guess I should use the bash completion. --=20 Felipe Contreras