zsh-workers
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: "Jérémie Roquet" <arkanosis@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Compilation fix for AIX (missing consts)
Date: Tue, 26 Apr 2011 12:16:19 -0700	[thread overview]
Message-ID: <BANLkTi=UQX0XKbUdhkiO_3-RYtSWPnvkkg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=wtU3LGu3vPbcD_DH5EQd=X9g0tw@mail.gmail.com>

2011/4/26 Jérémie Roquet <arkanosis@gmail.com>:
> I've had to fix the source to compile zsh on AIX. It looks like the
> protos were wrong anyway, but gcc doesn't complain on Linux…

Yeah, that section doesn't get included on Linux, since it has the
prototypes available in the public term.h and termcap.h.  I
(temporarily) commented out the #if/#endif lines and made all the
changes necessary to get it to compile without error, which also
required adding a "const" to the 3 "char *id" args that you didn't
change.  Since that section of the file is only supposed to be used
when the public prototypes aren't available, that should be better
than what we had before.

Does AIX have a conflicting header file?  Or just the calls weren't
matching the prototypes?  If the former, you may want to look into why
the Src/Modules/termcap.c code isn't setting either USES_TERMCAP_H or
USES_TERM_H for AIX.

..wayne..


  reply	other threads:[~2011-04-26 19:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 13:33 Jérémie Roquet
2011-04-26 19:16 ` Wayne Davison [this message]
2011-04-27 15:49   ` Jérémie Roquet
2011-04-27 18:54     ` Wayne Davison
2011-05-03 12:23       ` Jérémie Roquet
2011-05-06 13:51         ` Peter Stephenson
2011-05-06 14:16           ` Peter Stephenson
2011-05-09  9:54           ` Peter Stephenson
2011-05-09 10:33             ` Peter Stephenson
2011-05-03 10:23 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=UQX0XKbUdhkiO_3-RYtSWPnvkkg@mail.gmail.com' \
    --to=wayned@users.sourceforge.net \
    --cc=arkanosis@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).