From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6768 invoked by alias); 26 Apr 2011 19:16:23 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29058 Received: (qmail 25204 invoked from network); 26 Apr 2011 19:16:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.210.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=sEoloNFvoGg8y/5etR5z9fPbn+OYDW0TIYVk0kxJI/I=; b=W1RfRnc4R5XjPqVRwnjEL86brbPF5aiY+BPoDs/2/V/CsTsQ7bai4hKNYQmN70xENX HDnPVzj21cRLTcYbUk08GOTFHLoTwhZjv8GHc3M4HTC/Gv0yX7JkRlW7GJcYorQvhWyP 6x81siQ9JxbfycRBK9DhZznGLsHTrgVcudD64= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=BXtn3UKEvUJg5d8DaG8617lucRCe79wCtv7E78QdWPVNvMIxW1XQ/nvZ1rII/t3Za5 OwPC4UrWB8e/SralQltrVb1G6DuwgSvIODaWw6ySHfdSdSFN3qaxeFTdZcE0rRl+Yj/7 /XkbLw2AodDSQOjj9mnzWPl36kCRJGSWdHC/A= MIME-Version: 1.0 Sender: 4wayned@gmail.com In-Reply-To: References: Date: Tue, 26 Apr 2011 12:16:19 -0700 X-Google-Sender-Auth: cmxqAQzKxoLdXTJZu5MKTOZoNVY Message-ID: Subject: Re: [PATCH] Compilation fix for AIX (missing consts) From: Wayne Davison To: =?UTF-8?B?SsOpcsOpbWllIFJvcXVldA==?= Cc: zsh-workers@zsh.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2011/4/26 J=C3=A9r=C3=A9mie Roquet : > I've had to fix the source to compile zsh on AIX. It looks like the > protos were wrong anyway, but gcc doesn't complain on Linux=E2=80=A6 Yeah, that section doesn't get included on Linux, since it has the prototypes available in the public term.h and termcap.h. I (temporarily) commented out the #if/#endif lines and made all the changes necessary to get it to compile without error, which also required adding a "const" to the 3 "char *id" args that you didn't change. Since that section of the file is only supposed to be used when the public prototypes aren't available, that should be better than what we had before. Does AIX have a conflicting header file? Or just the calls weren't matching the prototypes? If the former, you may want to look into why the Src/Modules/termcap.c code isn't setting either USES_TERMCAP_H or USES_TERM_H for AIX. ..wayne..