From: Mikael Magnusson <mikachu@gmail.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: Speed improvement patch for __git_files and __git_files_relative
Date: Wed, 11 May 2011 15:44:48 +0200 [thread overview]
Message-ID: <BANLkTi=tqROxn8xcF10Zg+fiFaeDU4Tftw@mail.gmail.com> (raw)
In-Reply-To: <87sjsl2wqg.fsf@ft.bewatermyfriend.org>
On 11 May 2011 15:27, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Nikolai Weibull wrote:
>> I’ve now put together a patch for __git_files and
>> __git_files_relative. __git_files is a lot faster than previous
>> versions and __git_files_relative should be a lot faster too, now that
>> it only uses substitutions. (Well, there’s a for loop that iterates
>> over the file names to determine the common path prefix, but I see no
>> way of avoiding it.)
>>
>> It would be great if this could make it into the 4.3.12 release, so
>> please give it a try as soon as possible.
>
> Alright, I've been trying this. The speed improvement in my linux
> kernel clone is quite impressive.
>
> I'm running into a segfault, though. The git repository is located in
> `/tmp/linux-2.6'. I've changed a file (fs/adfs/dir.c) slightly and I'm
> doing this:
>
> % git add f<tab>
> % git add fs/<tab>
> % git add fs/adfs/<tab>
>
> And that's where the shell crashes. It's a build of today's HEAD.
>
> The kernel repository was cloned from this URI:
> <git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git>
>
> I don't have the time to look into this right now, so here's a back
> trace:
This crash seems to be getting pretty common now...
http://www.zsh.org/mla/workers/2011/msg00391.html
http://www.zsh.org/mla/workers/2011/msg00513.html
--
Mikael Magnusson
next prev parent reply other threads:[~2011-05-11 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 13:03 Nikolai Weibull
2011-05-11 13:27 ` Frank Terbeck
2011-05-11 13:44 ` Mikael Magnusson [this message]
2011-05-11 14:09 ` Completion crash owing to bad allocation Peter Stephenson
2011-05-13 23:26 ` Peter Stephenson
2011-05-14 2:56 ` Bart Schaefer
2011-05-17 12:55 ` Speed improvement patch for __git_files and __git_files_relative Nikolai Weibull
2011-05-17 13:01 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=tqROxn8xcF10Zg+fiFaeDU4Tftw@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).