From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-29220-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 16066 invoked by alias); 11 May 2011 13:44:56 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 29220
Received: (qmail 20846 invoked from network); 11 May 2011 13:44:54 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.212.43 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=tvI3AaWV0mvUGdUH+arG5a6bgbE3JUDi9+xzvF8U1nY=;
        b=BGD9MbJZpzvd1ZKT3um7+wd1ogT0TaEr7jKluka0oTdtGzi6DAV6h/s9f5X03BTnLq
         AgP0luyTKsU7Z04yP5TRNkTRdpcQgoxun/rn6ImmegbFWuePp5GmR9rQzcvThwZCAx7H
         kpsMyWg9Ycbb/AcjHkc8O9XMmpjaxEAkUweCE=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=f+opZViq8d/L65XBBkpnTf+m8hsSxo0wQ8i+Y0dBdss8rW3yWItW+Tp3GVhBnuHTf7
         80cfa6xTpLILZXjQHNIkMa6kN8fCqqkyWYzjXnqEXAac2mcZJ6oPGIL4+67dHlA1M0Xz
         vh6ZEyEmh1fIw3L9CZv0MPsytRfq04Y6qfEQE=
MIME-Version: 1.0
In-Reply-To: <87sjsl2wqg.fsf@ft.bewatermyfriend.org>
References: <BANLkTimkmU0ExT8duptV2V6_7NHSwANGOQ@mail.gmail.com>
	<87sjsl2wqg.fsf@ft.bewatermyfriend.org>
Date: Wed, 11 May 2011 15:44:48 +0200
Message-ID: <BANLkTi=tqROxn8xcF10Zg+fiFaeDU4Tftw@mail.gmail.com>
Subject: Re: Speed improvement patch for __git_files and __git_files_relative
From: Mikael Magnusson <mikachu@gmail.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 11 May 2011 15:27, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Nikolai Weibull wrote:
>> I=E2=80=99ve now put together a patch for __git_files and
>> __git_files_relative.  __git_files is a lot faster than previous
>> versions and __git_files_relative should be a lot faster too, now that
>> it only uses substitutions.  (Well, there=E2=80=99s a for loop that iter=
ates
>> over the file names to determine the common path prefix, but I see no
>> way of avoiding it.)
>>
>> It would be great if this could make it into the 4.3.12 release, so
>> please give it a try as soon as possible.
>
> Alright, I've been trying this.  The speed improvement in my linux
> kernel clone is quite impressive.
>
> I'm running into a segfault, though. The git repository is located in
> `/tmp/linux-2.6'. I've changed a file (fs/adfs/dir.c) slightly and I'm
> doing this:
>
>  % git add f<tab>
>  % git add fs/<tab>
>  % git add fs/adfs/<tab>
>
> And that's where the shell crashes. It's a build of today's HEAD.
>
> The kernel repository was cloned from this URI:
> <git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git>
>
> I don't have the time to look into this right now, so here's a back
> trace:

This crash seems to be getting pretty common now...
http://www.zsh.org/mla/workers/2011/msg00391.html
http://www.zsh.org/mla/workers/2011/msg00513.html

--=20
Mikael Magnusson