zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: tab inserts literal tab instead of completing at beginning of line
Date: Mon, 23 May 2011 19:11:22 +0200	[thread overview]
Message-ID: <BANLkTik-jO+28QnyM7g7yfdmWxTgo7hfpQ@mail.gmail.com> (raw)
In-Reply-To: <110523095742.ZM15497@torch.brasslantern.com>

On 23 May 2011 18:57, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On May 23,  4:55am, Mikael Magnusson wrote:
> }
> } On 23 May 2011 04:27, Bart Schaefer <schaefer@brasslantern.com> wrote:
> } > You're running into a strange combination of effects.  The completion
> } > internals initialize compstate[insert]=tab only when an actual tab is
> } > pressed, but the effect of explicitly assigning compstate[insert]=tab
> } > inside a completion function is to change the final keystroke into a
> } > self-insert.
>
> I'm trying to decide if this is worth documenting.
>
> } A tangent, I was just staring at these tests, and the (|[[:blank:]]*)
> } thing that appears on both sides, shouldn't the asterisk be to the left
> } of the blank when the thing is to the left of the word?
>
> I think you're correct about that.  There may be a few places that need
> that change.

I did a quick grep for the exact pattern that occurs here, and only
found it in _pids, and that already has the * on the right side.

> The two patches at the end of your message look fine if you want to
> commit one or the other (the "empty" one needs doc added, of course).

Okay, I'll commit the one without (the one with doesn't add it, it was
just on top of your patch). Is the patch to add "empty" pretty
uncontroversial if I add docs to it? I was a bit worried the subst +
length check might be a bit slow, but I ran a loop doing it 10000
times on a 1000 or so char long string and it only took 2 seconds or
so.

Is there some problem with zsh.org? I can't access www.zsh.org for the
mla to look up the number of my patch (gmail discards mailing lists
mails from yourself (sigh)), and iirc it was out a few days ago too.

-- 
Mikael Magnusson


  reply	other threads:[~2011-05-23 17:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 22:37 Mikael Magnusson
2011-05-19  5:47 ` Bart Schaefer
2011-05-19  9:36   ` Mikael Magnusson
2011-05-19 15:19     ` Bart Schaefer
2011-05-19 16:00       ` Mikael Magnusson
2011-05-20 21:55         ` Mikael Magnusson
2011-05-23  2:27           ` Bart Schaefer
2011-05-23  2:55             ` Mikael Magnusson
2011-05-23 16:57               ` Bart Schaefer
2011-05-23 17:11                 ` Mikael Magnusson [this message]
2011-05-24  2:55                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTik-jO+28QnyM7g7yfdmWxTgo7hfpQ@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).