From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 986 invoked by alias); 26 Apr 2011 22:25:41 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29071 Received: (qmail 12839 invoked from network); 26 Apr 2011 22:25:39 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.161.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=WQtm6nJrJUP8TSJxCgJYJWDj8yLHWjHUwSWH2KcRIRo=; b=EE34i6sYN7tgwBXFuT7BzQCo3Ma8uDH0rlY/6+5bXuQPazIcuo9jid/jZccUzHQy52 9QZoSGA2qGfspNCQZY8GAPvgIVYFBbRXJ5cEyRbhvh2owvZxQgyJwdvYH4oOMy2KdEKe XhS56zUrmVQqPHarz7vEcZ8rD9oQyak1uscvM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=RjC4Y8LXn2B1ROrbB9zXSHdQkTbf2hL2EAe3v1AF0qIlg7xTbXk0xTPoT8MoEg2zPE iBKBixN5wuEnJm9LO4Sx6nMpyi1Vx2uU3UA9RtKxB1bNzy+paY6TU9HrFZO6d3FgtQg0 lh9tCki2/Hw06zDiegbiCy0obn1T78DWzylyw= MIME-Version: 1.0 In-Reply-To: References: <87liyw7t0o.fsf@ft.bewatermyfriend.org> Date: Wed, 27 Apr 2011 01:25:32 +0300 Message-ID: Subject: Re: Slowness issue with git completion From: Felipe Contreras To: Nikolai Weibull Cc: Mikael Magnusson , Frank Terbeck , zsh-workers@zsh.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Apr 27, 2011 at 1:03 AM, Nikolai Weibull wrote: > On Tue, Apr 26, 2011 at 23:35, Felipe Contreras > wrote: >> On Wed, Apr 27, 2011 at 12:13 AM, Mikael Magnusson w= rote: > >>> It's only slow in repos as large as the linux one. > >> No. It's slow everywhere, it's *dead* slow on Linux. And BTW, there's >> thousands of developers working on Linux (the kernel), I guess we are >> not important. > > So perhaps you can improve it then. =C2=A0Or one of the thousands of > developers working on Linux (the kernel). =C2=A0(I don=E2=80=99t believe = that a > very large fraction of them actually use Zsh, And now I see why. > though, or someone would > have already provided a patch.) =C2=A0Or perhaps you could patch the kern= el > to make it faster? It works fine in bash. > I=E2=80=99ve spent innumerable hours on making it correct. =C2=A0I expect= someone > to pitch in a couple of hours to make it fast. Well, kernel and git developers have spent many more hours to make git fast, and this "correctness" is disrespecting that work because the time it takes to execute the completion is longer than the command itself. > I find your attitude in this thread rather offensive. Oh, if I say the current implementation is dead slow and unusable, you find that offensive? Maybe you should understand that criticism to code is not criticism to you. But I will tell you what I do when somebody finds a fatal flaw in my software; I fix it. If the person is offensive or cordial doesn't really matter, the fatal flaw is there. Now, how about you make a compromise between "correctness" and usability? There's many parts of the code marked as TODO, so I guess the code is not "perfectly correct". Add one more TODO, so in the meantime 'git add' shows unchanged files, which would make the rest of the commands as fast as they should be. I will tell you why I use completion; because I want to be more productive. If completion makes me less productive, I will obviously not use it... What's the point? I don't see why that is so hard to understand. Note that this is the case also for small projects. Are you interested in fixing this use-case even if it means to make some compromises in correctness or not? --=20 Felipe Contreras