PATCH: clarify which quotation marks to note

PATCH: clarify which quotation marks to note

[Mikael Magnusson]

I found the "Note the quotation marks" remark a bit confusing when I read this.

---
 Doc/Zsh/expn.yo |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Doc/Zsh/expn.yo b/Doc/Zsh/expn.yo
index ce122ca..023e60e 100644
--- a/Doc/Zsh/expn.yo
+++ b/Doc/Zsh/expn.yo
@@ -2360,8 +2360,8 @@ latter is inserted into the command line word by word.
 
 For example, suppose a directory contains a single file `tt(lonely)'.  Then
 the expression `tt(*(e:'reply=(${REPLY}{1,2})':))' will cause the words
-`tt(lonely1 lonely2)' to be inserted into the command line.  Note the
-quotation marks.
+`tt(lonely1)' and `tt(lonely2)' to be inserted into the command line.  Note
+the quotation marks in the expression.
 
 The form tt(PLUS())var(cmd) has the same effect, but no delimiters appear
 around var(cmd).  Instead, var(cmd) is taken as the longest sequence of
-- 
1.7.4-rc1

Re: PATCH: clarify which quotation marks to note

[Bart Schaefer]

On May 27,  3:33am, Mikael Magnusson wrote:
} Subject: PATCH: clarify which quotation marks to note
}
} I found the "Note the quotation marks" remark a bit confusing when I
} read this.

I still find it confusing. :-}

}  the expression `tt(*(e:'reply=(${REPLY}{1,2})':))' will cause the words
} +`tt(lonely1)' and `tt(lonely2)' to be inserted into the command line.  Note
} +the quotation marks in the expression.

    Note the single quotes inside the colons in the expression.

Perhaps??

Re: PATCH: clarify which quotation marks to note

[Mikael Magnusson]

On 27 May 2011 06:44, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On May 27,  3:33am, Mikael Magnusson wrote:
> } Subject: PATCH: clarify which quotation marks to note
> }
> } I found the "Note the quotation marks" remark a bit confusing when I
> } read this.
>
> I still find it confusing. :-}
>
> }  the expression `tt(*(e:'reply=(${REPLY}{1,2})':))' will cause the words
> } +`tt(lonely1)' and `tt(lonely2)' to be inserted into the command line.  Note
> } +the quotation marks in the expression.
>
>    Note the single quotes inside the colons in the expression.
>
> Perhaps??

Maybe we could say "The var(string) is quoted as noted above",
referring to this earlier sentence

Note that expansions must be quoted in the var(string)
to prevent them from being expanded before globbing is done.

Which is not incorrect, but you need to quote other things too,
*(e:):) is an error for example (a different error than *(e:\):) ).

It's weird how long you can stare at some stupid little thing and not
come up with a good concise way to write it down. Do we really need to
note the quotes at all? We already said that var(string) has to be
quoted. :)

-- 
Mikael Magnusson

Re: PATCH: clarify which quotation marks to note

[Mikael Magnusson]

On 27 May 2011 07:14, Mikael Magnusson <mikachu@gmail.com> wrote:
> On 27 May 2011 06:44, Bart Schaefer <schaefer@brasslantern.com> wrote:
>> On May 27,  3:33am, Mikael Magnusson wrote:
>> } Subject: PATCH: clarify which quotation marks to note
>> }
>> } I found the "Note the quotation marks" remark a bit confusing when I
>> } read this.
>>
>> I still find it confusing. :-}
>>
>> }  the expression `tt(*(e:'reply=(${REPLY}{1,2})':))' will cause the words
>> } +`tt(lonely1)' and `tt(lonely2)' to be inserted into the command line.  Note
>> } +the quotation marks in the expression.
>>
>>    Note the single quotes inside the colons in the expression.
>>
>> Perhaps??
>
> Maybe we could say "The var(string) is quoted as noted above",
> referring to this earlier sentence
>
> Note that expansions must be quoted in the var(string)
> to prevent them from being expanded before globbing is done.
>
> Which is not incorrect, but you need to quote other things too,
> *(e:):) is an error for example (a different error than *(e:\):) ).
>
> It's weird how long you can stare at some stupid little thing and not
> come up with a good concise way to write it down.

Okay, how about simply "note the quoting of var(string)"?

-- 
Mikael Magnusson

Re: PATCH: clarify which quotation marks to note

[Bart Schaefer]

On Aug 14,  9:52am, Mikael Magnusson wrote:
}
} Okay, how about simply "note the quoting of var(string)"?

That's fine with me.